Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config-resolver): resolve region first from regionHash #2969

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 1, 2021

Issue

Fixes: #2966

Description

Resolves region from regionHash first before checking for endpoint in partitionHash

Testing

  • Unit tests
  • Functional tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #2969 (00d3a27) into main (359c78c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2969   +/-   ##
=======================================
  Coverage   58.70%   58.70%           
=======================================
  Files         566      566           
  Lines       30315    30315           
  Branches     7460     7460           
=======================================
  Hits        17796    17796           
  Misses      12519    12519           
Impacted Files Coverage Δ
...es/config-resolver/src/regionInfo/getRegionInfo.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359c78c...00d3a27. Read the comment docs.

@trivikr trivikr merged commit 55f4e85 into aws:main Nov 1, 2021
@trivikr trivikr deleted the exact-match-for-region-name branch November 1, 2021 22:12
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The modular endpoints resolution ignores partition endpoint for non-regionalized entries
3 participants