Incorrect hostname when both useAccelerateEndpoint and useDualstackEndpoint are enabled

[trivikr]

Describe the bug

The SDK sets incorrect hostname when both useAccelerateEndpoint and useDualstackEndpoint are enabled

Your environment

SDK version number

@aws-sdk/client-s3@3.40.0

Is the issue in the browser/Node.js/ReactNative?

All

Details of the browser/Node.js/ReactNative version

$ node -v
v16.13.0

Steps to reproduce

• Enable transfer acceleration on a test bucket.
• Run the below example code.

Code

import { S3 } from "@aws-sdk/client-s3";

const region = "us-west-2";
const useAccelerateEndpoint = true;
const useDualstackEndpoint = true;

// Bucket with transfer acceleration enabled.
const Bucket = "trivikr-accelerate-testing";

const client = new S3({ region, useAccelerateEndpoint, useDualstackEndpoint });
await client.listObjects({ Bucket });

Observed behavior

throws getaddrinfo ENOTFOUND error.

Output

node:internal/process/esm_loader:94
    internalBinding('errors').triggerUncaughtException(
                              ^

Error: getaddrinfo ENOTFOUND trivikr-accelerate-testing.s3-accelerate.dualstack.us-west-2.amazonaws.com
    at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:71:26) {
  errno: -3008,
  code: 'ENOTFOUND',
  syscall: 'getaddrinfo',
  hostname: 'trivikr-accelerate-testing.s3-accelerate.dualstack.us-west-2.amazonaws.com',
  '$metadata': { attempts: 1, totalRetryDelay: 0 }
}

Expected behavior

Sets correct hostname when both useAccelerateEndpoint and useDualstackEndpoint

[trivikr]

For the example provided in the bug, the hostname is

trivikr-accelerate-testing.s3-accelerate.dualstack.us-west-2.amazonaws.com

It should be:

trivikr-accelerate-testing.s3-accelerate.dualstack.amazonaws.com

Equivalent AWS CLI code:

$ aws --version
aws-cli/2.2.12 Python/3.8.8 Darwin/20.6.0 exe/x86_64 prompt/off

$ aws configure set default.s3.use_dualstack_endpoint true

$ aws s3api list-objects --bucket trivikr-accelerate-testing --endpoint-url https://s3-accelerate.amazonaws.com --debug 2>&1 | grep "urllib3.connectionpool"
2021-11-08 09:49:35,075 - MainThread - urllib3.connectionpool - DEBUG - Starting new HTTPS connection (1): trivikr-accelerate-testing.s3-accelerate.amazonaws.com:443
2021-11-08 09:49:35,387 - MainThread - urllib3.connectionpool - DEBUG - https://trivikr-accelerate-testing.s3-accelerate.amazonaws.com:443 "GET /?encoding-type=url HTTP/1.1" 200 None

[trivikr]

This issue was introduced in v3.40.0 release. It's not reproducible with v3.39.0

[trivikr]

This issue happens as .dualstack is prefixed in build stage

Code

import { S3 } from "@aws-sdk/client-s3";

const logHostnameMiddleware = (next) => async (args) => {
  console.log({ hostname: args.request.hostname });
  return next(args);
};
const logHostnameMiddlewareOptions = { step: "build" };

const region = "us-west-2";
const useAccelerateEndpoint = true;
const useDualstackEndpoint = true;

// Bucket with transfer acceleration enabled.
const Bucket = "trivikr-accelerate-testing";

const client = new S3({ region, useAccelerateEndpoint, useDualstackEndpoint });
client.middlewareStack.add(logHostnameMiddleware, logHostnameMiddlewareOptions);
await client.listObjects({ Bucket });

Output

{ hostname: 's3.dualstack.us-west-2.amazonaws.com' }

In v3.39.0 and earlier, the .dualstack was added in bucketEndpointMiddleware

[trivikr]

This happens as resolution of useDualstackEndpoint is done while resolving endpoint, as the configuration is now applicable to all clients.
Added in #2947

The .dualstack now comes from endpoint resolution:

aws-sdk-js-v3/clients/client-s3/src/endpoints.ts

Lines 351 to 370 in f2fb280

	"us-west-2": {
	variants: [
	{
	hostname: "s3.us-west-2.amazonaws.com",
	tags: [],
	},
	{
	hostname: "s3-fips.dualstack.us-west-2.amazonaws.com",
	tags: ["dualstack", "fips"],
	},
	{
	hostname: "s3-fips.us-west-2.amazonaws.com",
	tags: ["fips"],
	},
	{
	hostname: "s3.dualstack.us-west-2.amazonaws.com",
	tags: ["dualstack"],
	},
	],
	},

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.