Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support awsQueryError trait #3174

Merged
merged 7 commits into from
Jan 13, 2022
Merged

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jan 10, 2022

Issue

Internal JS-2681
smithy-ts: smithy-lang/smithy-typescript#489
Similar to: aws/aws-sdk-go-v2#1283

Description

Adds support for awsQueryError trait

Testing

Protocol tests are successful


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review January 12, 2022 16:03
@trivikr trivikr requested a review from a team as a code owner January 12, 2022 16:03
@trivikr trivikr changed the title [WIP] feat: Support awsQueryError trait feat: Support awsQueryError trait Jan 12, 2022
@trivikr
Copy link
Member Author

trivikr commented Jan 12, 2022

The Java CI is failing, as the change from smithy-typescript in smithy-lang/smithy-typescript#489 is not available. Verified that the CI commands from codegen-ci are successful in the workspace.

@trivikr trivikr merged commit 351bd3a into aws:main Jan 13, 2022
@trivikr trivikr deleted the aws-query-error-trait branch January 13, 2022 17:24
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants