Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util-defaults-mode-browser): import bowser by default export #3203

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

AllanZhengYP
Copy link
Contributor

Issue

Resolves #3202

Description

Similar to #1991, fix Vite build by importing bowser from default export

Testing

./node_modules/.bin/snowpack build
[24:35:27] [snowpack] Hint: run "snowpack init" to create a project config file. Using defaults...
[24:35:27] [snowpack] ! building files...
[24:35:27] [snowpack] ✔ files built. [0.05s]
[24:35:27] [snowpack] ! building dependencies...
[24:35:31] [snowpack] ✔ dependencies built. [3.26s]
[24:35:31] [snowpack] ! writing to disk...
[24:35:31] [snowpack] ✔ write complete. [0.02s]
[24:35:31] [snowpack] ▶ Build Complete!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@AllanZhengYP AllanZhengYP requested a review from a team as a code owner January 16, 2022 23:38
@Thomasorus
Copy link

Thanks for your PR, encountered this bug today. I hope it will be merged soon.

@AllanZhengYP AllanZhengYP merged commit 5187be2 into aws:main Jan 19, 2022
@github-actions
Copy link

github-actions bot commented Feb 3, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite apps will not build because of resolving imports
3 participants