Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The transpiled files for aws-protocoltests-* are created in source folder #3212

Closed
trivikr opened this issue Jan 19, 2022 · 2 comments · Fixed by #3213
Closed

The transpiled files for aws-protocoltests-* are created in source folder #3212

trivikr opened this issue Jan 19, 2022 · 2 comments · Fixed by #3213
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 19, 2022

Describe the bug

The transpiled files for aws-protocoltests-* are created in source folder

Your environment

SDK version number

@aws-sdk/package-name@version

Is the issue in the browser/Node.js/ReactNative?

Browser/Node.js/ReactNative

Details of the browser/Node.js/ReactNative version

Paste output of npx envinfo --browsers or node -v or react-native -v

Steps to reproduce

Run yarn build:protocols

Observed behavior

Notice that transpiled *.js are created in src folder.

$ git status | head
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        private/aws-protocoltests-ec2/src/EC2Protocol.js
        private/aws-protocoltests-ec2/src/EC2ProtocolClient.js
        private/aws-protocoltests-ec2/src/commands/EmptyInputAndEmptyOutputCommand.js
        private/aws-protocoltests-ec2/src/commands/EndpointOperationCommand.js
        private/aws-protocoltests-ec2/src/commands/EndpointWithHostLabelOperationCommand.js

Expected behavior

The transpiled files should exist in dist-* folders

@trivikr trivikr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 19, 2022
@trivikr
Copy link
Member Author

trivikr commented Jan 19, 2022

This happens because the following TypeScript configuration is not set up in tsconfig.types.json

    "emitDeclarationOnly": true

@github-actions
Copy link

github-actions bot commented Feb 4, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant