Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credential-provider-process): refactor into modular components #3287

Merged
merged 14 commits into from
Feb 9, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 7, 2022

Issue

Refs: #3285 (comment)

Description

  • Refactors credential-provider-process into individual components.
  • Ensures that unit tests mocks only the required components.

Testing

Unit testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review February 7, 2022 22:33
@trivikr trivikr requested a review from a team as a code owner February 7, 2022 22:33
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me

@trivikr trivikr merged commit 2b64304 into aws:main Feb 9, 2022
@trivikr trivikr deleted the refactor-credential-provider-process branch February 9, 2022 21:26
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants