Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(credential-provider-env): refactor into modular components #3293

Merged
merged 3 commits into from
Feb 14, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 9, 2022

Issue

Performed refactor while passing by #3289

Description

  • Moves fromEnv to it's own file.
  • Converts fromEnv to arrow function.
  • Converts Promise to async function.
  • Does not populate Credential keys, if value is not defined.
  • Adds missing test case for individual required key missing.

Testing

Unit testing


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 9, 2022 02:54
@trivikr trivikr force-pushed the refactor-credential-provider-env branch from d214399 to efc366c Compare February 10, 2022 23:03
@trivikr trivikr merged commit e0697ed into aws:main Feb 14, 2022
@trivikr trivikr deleted the refactor-credential-provider-env branch February 14, 2022 19:29
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants