Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): update version to v3.50.0 #3300

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Feb 11, 2022

Issue

Discussed internally over Slack: The command lerna:version fails, and will block v3.51.0 release.

$ yarn lerna:version
yarn run v1.22.17
$ lerna version --exact --conventional-commits --no-push --no-git-tag-version --no-commit-hooks --loglevel silent --no-private --yes
node:events:368
      throw er; // Unhandled 'error' event
      ^

Error: warning: refname 'v3.50.0' is ambiguous.
    at DestroyableTransform._transform (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/git-raw-commits/index.js:83:30)
    at DestroyableTransform.Transform._read (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    at DestroyableTransform.Transform._write (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/readable-stream/lib/_stream_transform.js:172:83)
    at doWrite (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/readable-stream/lib/_stream_writable.js:428:64)
    at writeOrBuffer (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/readable-stream/lib/_stream_writable.js:417:5)
    at DestroyableTransform.Writable.write (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/readable-stream/lib/_stream_writable.js:334:11)
    at Socket.ondata (node:internal/streams/readable:754:22)
    at Socket.emit (node:events:402:35)
    at addChunk (node:internal/streams/readable:315:12)
    at readableAddChunk (node:internal/streams/readable:285:11)
Emitted 'error' event on Readable instance at:
    at DestroyableTransform._transform (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/git-raw-commits/index.js:83:16)
    at DestroyableTransform.Transform._read (/local/home/trivikr/workspace/aws-sdk-js-v3/node_modules/readable-stream/lib/_stream_transform.js:184:10)
    [... lines matching original stack trace ...]
    at readableAddChunk (node:internal/streams/readable:285:11)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Description

Manually update version to v3.50.0 to unblock the release, while we debug the release scripts.

Testing

Verified that lerna:version command is successful.

$ yarn lerna:version
yarn run v1.22.17
$ lerna version --exact --conventional-commits --no-push --no-git-tag-version --no-commit-hooks --loglevel silent --no-private --yes

Changes:
 - @aws-sdk/client-accessanalyzer: 3.50.0 => 3.51.0
 ...
 - @aws-sdk/util-user-agent-node: 3.50.0 => 3.51.0

Done in 56.19s.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr requested a review from a team as a code owner February 11, 2022 04:01
@trivikr trivikr changed the title fix(package.json): udpate version to v3.50.0 fix(package.json): update version to v3.50.0 Feb 11, 2022
@trivikr trivikr merged commit 23a2463 into aws:main Feb 11, 2022
@trivikr trivikr deleted the update-root-package-json-version branch February 11, 2022 07:57
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants