fix(middleware-content-length): swallow error if content-length computation fails #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt-length computation fails
trivikr
changed the title
AllanZhengYP
approved these changes
Mar 15, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #3418
Description
Switches back to previous experience where header 'content-length' was not set, and no other header was set.
The existing behavior was added after checking RFC 7230 in #3400 (comment), and AWS SDK for Python behavior in #3400 (comment). The issue happened in Transcribe Streaming as it uses HTTP/2, and the middleware doesn't check for version of HTTP protocol for setting 'transfer-encoding' header.
Testing
Unit tests are absent, and to be added separately to the module.
No additional testing needed, as it's basic reverting to the previous flow.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.