Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client-kinesis): disable Kinesis ResourceNotFoundException test #3584

Merged
merged 1 commit into from
May 2, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented May 2, 2022

Issue

Internal JS-3272

Description

This commit disables kinesis integration test, as it's failing in our internal preview builds.
It would be enabled after the v3.81.0 release, after a deep-dive and fixing the issue.

We suspected the issue was caused by #3577, but it's not reproducible in workspace. Disable the legacy integration test, as the code change was tested with new integration test.

Testing

Verified that Kinesis legacy test is skipped

$ yarn test:integration:legacy --fail-fast -t @kinesis


yarn run v1.22.18
$ cucumber-js --fail-fast --fail-fast -t @kinesis


0 scenarios
0 steps
0m00.000s
Done in 0.61s.

Verified that manually written test is successful:

// kinesis.mjs
import { Kinesis } from "../aws-sdk-js-v3/clients/client-kinesis/dist-cjs/index.js";

const client = new Kinesis();
try {
  await client.describeStream({StreamName: "XXINVALIDXX"});
} catch (error) {
  console.log({errorName: error.name });
}
$ node -v
v16.14.2

$ node kinesis.mjs
{ errorName: 'ResourceNotFoundException' }

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review May 2, 2022 17:42
@trivikr trivikr requested a review from a team as a code owner May 2, 2022 17:42
@trivikr trivikr merged commit aeb63b3 into aws:main May 2, 2022
@trivikr trivikr deleted the disable-kinesis-integ-test branch May 2, 2022 17:57
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants