Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codegen): add codegen indicator comment to all generated files #3592

Merged
merged 2 commits into from
May 5, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 4, 2022

Issue

paired with smithy-lang/smithy-typescript#538

Description

Adds generated code indicator comment to the top of smithy generated files.

Note: this previously included generated readme.md files written by the smithy TypeScriptWriter.

  • modified smithy-ts to not write the attribution header comment into non-ts files.
  • added a markdown compatible comment to the local template here

Testing

no runtime changes

@AllanZhengYP
Copy link
Contributor

GitHub diff page crashes, but I have check'd out to my VSCode-insiders(official version will crash too) and validated the diff.

🚀🚀

@kuhe
Copy link
Contributor Author

kuhe commented May 5, 2022

overriding merge due to inability to open the review page

@kuhe kuhe merged commit 567a530 into aws:main May 5, 2022
@kuhe kuhe deleted the codegen-attribution branch May 5, 2022 15:18
@kuhe kuhe self-assigned this May 5, 2022
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants