fix(signature-v4): getCanonicalHeaders ignores undefined header values #3789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like there are certain edge cases that cause header values to become undefined. In these scenarios we'll hit an exception.
AllanZhengYP
approved these changes
Jul 11, 2022
|
The change looks good to me. Thanks for the contribution! @lew-gordon |
AllanZhengYP
changed the title
|
@AllanZhengYP this change looks like it cause a kinesis client signature regression in 128, is that the patch you have in 129? Moving back to 127 corrected it. "'Host' or ':authority' must be a 'SignedHeader' in the AWS Authorization." Update: nm just read through 3796 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue #3788
Description
It seems like there are certain edge cases that cause header values to become undefined. In these scenarios we'll hit an exception.
Testing
Tested via provided unit test.
Additional context
I'm not sure that will necessary fix #3788, but at least it should handle one odd scenario.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.