fix(smithy-client): rfc-7231 date-time value #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hi @dustin-lennon, the proposed change looks reasonable for me.
Could you please add unit test for this?. Please let us know if you have any questions about it.
|
Hello @yenfryherrerafeliz I have added the unit test for this. Please check latest commit. |
yenfryherrerafeliz
approved these changes
Jul 22, 2022
|
what's the status? |
kuhe
approved these changes
Jul 25, 2022
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #3813
The regexp does not handle times with single digit hours
Description
Presently, if a date-time value comes back with a single digit for the hour, the regular expression checks fail throwing back
TypeError: Invalid RFC-7231 date-time valueBy adjusting the regular expression to accept either 1 or 2 length digits for the hour, the checks now pass.
Testing
Unit testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.