Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer the old version #4662

Closed
jhylton opened this issue Apr 25, 2023 · 5 comments
Closed

Prefer the old version #4662

jhylton opened this issue Apr 25, 2023 · 5 comments
Assignees
@MYoung25
Labels
documentation This is a problem with documentation. p2 This is a standard priority issue queued This issues is on the AWS team's backlog

Comments

@jhylton
Copy link

jhylton commented Apr 25, 2023

Describe the issue

the new version does not take into account command output. Makes it dificult to understand what will be returned without running the command.

Links

https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/preview/client/ec2/command/DescribeInstancesCommand/
@jhylton jhylton added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Apr 25, 2023
@RanVaknin RanVaknin removed the needs-triage This issue or PR still needs to be triaged. label Apr 25, 2023
@MYoung25
Copy link
Contributor

Hi! Thanks for taking the time to leave us feedback, we hear you and understand your request to include the response types.

I will look into ways for us to include the return types in the example syntax. You are not alone in wanting this so I'll try to prioritize this

@kuhe
Copy link
Contributor

kuhe commented Apr 27, 2023

@MYoung25 the output shape could be used to generate a structural type hint similar to the input shape.

@MYoung25
Copy link
Contributor

@kuhe That is exactly what I was thinking

@RanVaknin RanVaknin added p2 This is a standard priority issue queued This issues is on the AWS team's backlog labels Apr 27, 2023
@RanVaknin RanVaknin removed their assignment Apr 27, 2023
@MYoung25
Copy link
Contributor

MYoung25 commented May 4, 2023

I'm pleased to confirm output shapes are now showing in the Example Syntax! Please don't hesitate to continue leaving us feedback, and thank you again for taking the time to let us know how we can get better

@MYoung25 MYoung25 closed this as completed May 4, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MYoung25 MYoung25

Labels
documentation This is a problem with documentation. p2 This is a standard priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kuhe @jhylton @MYoung25 @RanVaknin