Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the code sample did not work without Buffer.from() in typescript. #4782

Closed
ssagli opened this issue Jun 2, 2023 · 4 comments
Closed

the code sample did not work without Buffer.from() in typescript. #4782

ssagli opened this issue Jun 2, 2023 · 4 comments
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue queued This issues is on the AWS team's backlog

Comments

@ssagli
Copy link

ssagli commented Jun 2, 2023

Describe the issue

I was trying out the code sample given in the lambda invokeCommand documentation, and it kept giving me the type error. I was looking for a solution and found this #4475 and was able to resolve the issue. I would appreciate it if you could update the documentation to add Buffer.from() for the Payload value.

Links

https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/preview/client/lambda/command/InvokeCommand/
@ssagli ssagli added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Jun 2, 2023
@RanVaknin RanVaknin added p2 This is a standard priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Jun 2, 2023
@RanVaknin
Copy link
Contributor

Related #4786

@kuhe kuhe added p3 This is a minor priority issue and removed p2 This is a standard priority issue labels Jun 23, 2023
@kuhe
Copy link
Contributor

kuhe commented Sep 21, 2023

fixed in smithy-lang/smithy-typescript#777

@RanVaknin
Copy link
Contributor

image

Type documentation expanded.
Closing.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
documentation This is a problem with documentation. p3 This is a minor priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kuhe @RanVaknin @ssagli