Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): remove deprecated packages from sdkVersions.properties #4898

Merged

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Jun 29, 2023

Issue

Issue number, if available, prefixed with "#"

Description

Currently, the sdkVersions.properties resource file is generated with the current version of each client and dependency package including packages that have been deprecated.

For example, karma-credential-loader has been deprecated and the last published version was 3.40.0: https://www.npmjs.com/package/@aws-sdk/karma-credential-loader

However, the sdkVersions.properties resource file is currently being generated with this line:

@aws-sdk/karma-credential-loader=3.363.0

This PR updates build.gradle.kts to exclude packages which have been deprecated by setting private: true in their package.json.

Testing

Ran ./gradlew clean build from the /codegen directory and confirmed that the generate file at /codegen/smithy-aws-typescript-codegen/build/resources/main/software/amazon/smithy/aws/typescript/codegen/sdkVersions.properties no longer included a line for karma-credential-loader.

Additional context

Add any other context about the PR here.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from a team as a code owner June 29, 2023 22:36
@srchase srchase merged commit d7299d5 into aws:main Jun 30, 2023
3 checks passed
@srchase srchase deleted the remove-deprecated-packages-from-sdkVersions branch June 30, 2023 15:40
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants