Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-middleware-test): add tsconfig files from aws-client-api-test #4911

Merged
merged 1 commit into from Jul 3, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 3, 2023

Issue

Internal JS-4460

Description

The internal builds started failing since the #4850 was merged with Error:

[Error: ENOENT: no such file or directory, open 'private/aws-middleware-test/tsconfig.types.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'private/aws-middleware-test/tsconfig.types.json'
}

This PR just adds default TSConfig files, copied from aws-client-api-test

Testing

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr marked this pull request as ready for review July 3, 2023 17:49
@trivikr trivikr requested a review from a team as a code owner July 3, 2023 17:49
@trivikr
Copy link
Member Author

trivikr commented Jul 3, 2023

Created a feature request for skipping downleveling of packages under private folder at #4912

@trivikr trivikr merged commit acb7753 into aws:main Jul 3, 2023
3 checks passed
@trivikr trivikr deleted the tsconfig-aws-middleware-test branch July 3, 2023 17:56
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants