Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scripts): skip downleveling of packages in private folder #4914

Merged
merged 1 commit into from Jul 3, 2023

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jul 3, 2023

Issue

Fixes: #4912

Description

Skips downleveling of packages in private folder

Testing

ToDo: Verified that yarn build:types:downlevel succeeded with the repo setup prior to fix in #4911

$ yarn build:all && yarn build:types:downlevel
...
Done in 114.59s.

Verified that downlevel types were created for clients.

$ ls clients/client-s3/dist-types/ts3.4
commands  index.d.ts  pagination  runtimeConfig.browser.d.ts  runtimeConfig.native.d.ts  S3Client.d.ts  waiters
endpoint  models      protocols   runtimeConfig.d.ts          runtimeConfig.shared.d.ts  S3.d.ts

$ ls private/aws-echo-service/dist-types/ts3.4
ls: cannot access private/aws-echo-service/dist-types/ts3.4: No such file or directory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the skip-downlevel-private-folder branch from 4815e51 to 5b2aaad Compare July 3, 2023 18:34
@trivikr trivikr marked this pull request as ready for review July 3, 2023 19:05
@trivikr trivikr requested a review from a team as a code owner July 3, 2023 19:05
@trivikr trivikr merged commit 93a194f into aws:main Jul 3, 2023
3 checks passed
@trivikr trivikr deleted the skip-downlevel-private-folder branch July 3, 2023 19:05
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip downleveling of packages inside private folder
2 participants