feat(credential-providers): lazy load STS & SSO clients in credential providers #5681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
feat/defer-auth-client
branch
5 times, most recently
from
d4cf9e4
to
4bd6c32
Compare
kuhe
force-pushed
the
feat/defer-auth-client
branch
11 times, most recently
from
c0db7e0
to
6d909ab
Compare
kuhe
force-pushed
the
feat/defer-auth-client
branch
12 times, most recently
from
76612ae
to
1650823
Compare
kuhe
force-pushed
the
feat/defer-auth-client
branch
5 times, most recently
from
561131a
to
ed31aa3
Compare
siddsriv
approved these changes
Jan 27, 2024
3 tasks
kuhe
force-pushed
the
feat/defer-auth-client
branch
2 times, most recently
from
02c0b9e
to
25dd1ff
Compare
kuhe
force-pushed
the
feat/defer-auth-client
branch
from
25dd1ff
to
ee8c4b9
Compare
kuhe
force-pushed
the
feat/defer-auth-client
branch
from
e729721
to
b6c9839
Compare
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a followup to #5677 (dynamic imports for Node.js credential providers),
this PR uses the same lazy-loading mechanism for the STS and SSO clients used in credential resolution.
Additionally, the PR uses peerDependency declaration as an alternative to the bundling solution given in #5049.
Browser Testing
Node.js testing