Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export NativeAttributeValue from @aws-sdk/lib-dynamodb #5981

Closed
1 of 2 tasks
trivikr opened this issue Apr 9, 2024 · 1 comment · Fixed by #5982
Closed
1 of 2 tasks

Export NativeAttributeValue from @aws-sdk/lib-dynamodb #5981

trivikr opened this issue Apr 9, 2024 · 1 comment · Fixed by #5982
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p3 This is a minor priority issue queued This issues is on the AWS team's backlog

Comments

@trivikr
Copy link
Member

trivikr commented Apr 9, 2024

Describe the feature

Export NativeAttributeValue from @aws-sdk/lib-dynamodb

Use Case

When working with any types which take NativeAttributeValue in lib-dynamodb, they need to be imported from util-dynamodb

Example:

import { DynamoDB } from "@aws-sdk/client-dynamodb";
import { DynamoDBDocument } from "@aws-sdk/lib-dynamodb";
import { NativeAttributeValue } from "@aws-sdk/util-dynamodb";

const ddbClient = new DynamoDB({});
const ddbDocClient = DynamoDBDocument.from(ddbClient);
const key: Record<string, NativeAttributeValue> = {};

Proposed Solution

Re-export NativeAttributeValue from lib-dynamodb so that it can be imported from there

import { DynamoDB } from "@aws-sdk/client-dynamodb";
import { DynamoDBDocument, NativeAttributeValue } from "@aws-sdk/lib-dynamodb";

const ddbClient = new DynamoDB({});
const ddbDocClient = DynamoDBDocument.from(ddbClient);
const key: Record<string, NativeAttributeValue> = {};

Other Information

Noticed in aws/aws-sdk-js-codemod#824

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.549.0

Environment details (OS name and version, etc.)

TypeScript on any JavaScript runtime

@trivikr trivikr added feature-request New feature or enhancement. May require GitHub community feedback. needs-triage This issue or PR still needs to be triaged. p3 This is a minor priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Apr 9, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback. p3 This is a minor priority issue queued This issues is on the AWS team's backlog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant