Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tsconfig.test.tsbuildinfo appear as untracked files in some packages #750

Closed
trivikr opened this issue Jan 17, 2020 · 3 comments
Closed
Labels
bug This issue is a bug.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 17, 2020

Describe the bug
tsconfig.test.tsbuildinfo appear as untracked files in following packages:

  • middleware-sdk-machinelearning
  • middleware-sdk-s3-control

To Reproduce (observed behavior)
Run codegen or yarn pretest:all on smithy-codegen
Notice under untracked files:

        packages/middleware-sdk-machinelearning/tsconfig.test.tsbuildinfo
        packages/middleware-sdk-s3-control/tsconfig.test.tsbuildinfo

Expected behavior
tsconfig.test.tsbuildinfo should be ignored by git

@trivikr trivikr added the bug This issue is a bug. label Jan 17, 2020
@trivikr
Copy link
Member Author

trivikr commented Jan 17, 2020

Fixed by #752

@trivikr trivikr closed this as completed Jan 17, 2020
@trivikr
Copy link
Member Author

trivikr commented Jan 20, 2020

Confirmed that tsbuildinfo is added in all .gitignore files as the following command returns empty result in packages folder:

grep -L "tsbuildinfo" **/.gitignore

@lock
Copy link

lock bot commented Jan 28, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

1 participant