Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extended URI encoding #915

Merged
merged 3 commits into from
Feb 11, 2020
Merged

Conversation

srchase
Copy link
Contributor

@srchase srchase commented Feb 11, 2020

Fixes: #866

Adds extendedEncodeURI function to wrap encodeURIComponent and encode additional characters, !, ', (, ), and *, to adhere to RFC 3986.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@kstich kstich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other locations that will need their uri encoding function updated in smithy-typescript as well after this.

packages/smithy-client/src/extended-encode-uri.ts Outdated Show resolved Hide resolved
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #915 into smithy-codegen will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           smithy-codegen     #915   +/-   ##
===============================================
  Coverage           92.12%   92.12%           
===============================================
  Files                 145      145           
  Lines                2908     2908           
  Branches              513      513           
===============================================
  Hits                 2679     2679           
  Misses                229      229

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 454f5ef...6e5e50b. Read the comment docs.

@srchase srchase merged commit 983027f into aws:smithy-codegen Feb 11, 2020
@srchase srchase deleted the extended-encode-uri branch February 11, 2020 19:59
@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@lock
Copy link

lock bot commented Feb 21, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants