-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extended URI encoding #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are other locations that will need their uri encoding function updated in smithy-typescript
as well after this.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## smithy-codegen #915 +/- ##
===============================================
Coverage 92.12% 92.12%
===============================================
Files 145 145
Lines 2908 2908
Branches 513 513
===============================================
Hits 2679 2679
Misses 229 229 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Fixes: #866
Adds extendedEncodeURI function to wrap encodeURIComponent and encode additional characters, !, ', (, ), and *, to adhere to RFC 3986.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.