fix(fast-xml-parser): populate contents from '#text' if available

[trivikr]

Issue #, if available:
Option 2 for fixing #987

Description of changes:

• fix(fast-xml-parser): populate contents from '#text' if available
• Verified the fix by updating node_modules/@aws-sdk/client-s3/dist/cjs/protocols/Aws_restXml.js with the reproducible code given in s3.getBucketLocation returns undefined for LocationConstraint #987
• Ran integration tests in https://github.com/trivikr/aws-sdk-js-v3/tree/s3-bucketLocation-parser-fix-integ-test:
  • Verified that the failing test in s3.getBucketLocation returns undefined for LocationConstraint #987 is successful
  • Verified that all other tests succeeding before this code change are also succeeding after this code change

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[trivikr]

The update was verified by using modified version of code in https://github.com/trivikr/xml-parser-comparison:

Code:

const fastXmlParser = require("fast-xml-parser");
const { readFileSync } = require("fs");

const xmlData = readFileSync("example.xml").toString();
const parsedObj = fastXmlParser.parse(xmlData, {
  attributeNamePrefix: "",
  ignoreAttributes: false
});
const textNodeName = "#text";
const key = Object.keys(parsedObj)[0];
const parsedObjToReturn = parsedObj[key];
if (parsedObjToReturn[textNodeName]) {
  parsedObjToReturn[key] = parsedObjToReturn[textNodeName];
  delete parsedObjToReturn[textNodeName];
}
console.log(JSON.stringify(parsedObjToReturn, null, 2));

When example.xml contains:

<?xml version="1.0"?>
<AccessControlPolicy
	xmlns="http://s3.amazonaws.com/doc/2006-03-01/">
	<Owner>
		<DisplayName>trivikr</DisplayName>
	</Owner>
</AccessControlPolicy>

Output is:

{
  "xmlns": "http://s3.amazonaws.com/doc/2006-03-01/",
  "Owner": {
    "DisplayName": "trivikr"
  }
}

When example.xml contains:

<?xml version="1.0"?>
<LocationConstraint xmlns="http://s3.amazonaws.com/doc/2006-03-01/">EU</LocationConstraint>

Output is:

{
  "xmlns": "http://s3.amazonaws.com/doc/2006-03-01/",
  "LocationConstraint": "EU"
}

[aws-sdk-js-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.