Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParamValidator fails to properly validate document type trait #3991

Closed
4 tasks done
JavierLuna opened this issue Dec 17, 2021 · 0 comments · Fixed by #4011
Closed
4 tasks done

ParamValidator fails to properly validate document type trait #3991

JavierLuna opened this issue Dec 17, 2021 · 0 comments · Fixed by #4011
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@JavierLuna
Copy link

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug
I'm using Smithy's document type trait to generate an SDK. The generation itself goes well, but when attempting to use it to call my service, I get an UnexpectedParameter: Unexpected key 'test' found in params.myDocumentType.

The validation error appears to come from ParamValidator, I'm guessing #3808 did not adapt parameter validation.

Disabling paramValidation works: The SDK does the call and the service processes it correctly.

Is the issue in the browser/Node.js?
Node.js

If on Node.js, are you running this on AWS Lambda?
Local

Details of the browser/Node.js version

$ node -v
v14.17.0

SDK version number
Example: v2.1007.0

To Reproduce (observed behavior)
Attempt to make any call to a service that has a property with the document type trait.

Expected behavior
Parameter validation correctly validates my document property and makes the call to my service.

Screenshots
No

Additional context
No

@JavierLuna JavierLuna added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant