Resource s3-2006-03-01 has an incorrect request element for Complete Multipart Upload

[tatsuya6502]

Hi,

• aws-sdk-php2 2.4.1
• PHP 5.3.3

I found Aws\S3\Model\MultipartUpload\UploadBuilder's upload() function generates an invalid request element for Complete Multipart Upload.

According to the S3 API Reference (API Version 2006-03-01)(1), the top level XML element should be CompleteMultipartUpload. However upload() generates MultipartUpload instead. I ran into this problem while running the SDK against a S3 API compatible storage software.

(1) http://docs.aws.amazon.com/AmazonS3/latest/API/mpUploadComplete.html

I believe the resource file s3-2006-03-01.php has the wrong element:

https://github.com/aws/aws-sdk-php/blob/d332784fc6/src/Aws/S3/Resources/s3-2006-03-01.php#L119

        'CompleteMultipartUpload' => array(
            'httpMethod' => 'POST',
            'uri' => '/{Bucket}{/Key*}',
            ...

            'data' => array(
                'xmlRoot' => array(
                    'name' => 'MultipartUpload',
                    'namespaces' => array(
                        'http://s3.amazonaws.com/doc/2006-03-01/',

Could you please change it to CompleteMultipartUpload so that we can run the SDK against any S3 API compatible storage?

Thanks,

[jeremeamia]

Interesting... we'll look into this. This does not cause an error with S3, but, like you have observed, it doesn't seem to match the docs.

[tatsuya6502]

Thank you for looking into this. I checked AWS SDK for Java and Ruby, and found that they have been using CompleteMultipartUpload element from very beginning.

AWS SDK for Java, RequestXmlFactory.java, first commit on Nov 9,2010

xml.start("CompleteMultipartUpload");

AWS SDK for Ruby, s3/client.rb, first commit on Jul 14, 2011

req.body =
  "<CompleteMultipartUpload>#{parts_xml}</CompleteMultipartUpload>"

I have no idea why MultipartUpload does not cause an error with S3, but I would recommend to follow the API document and use CompleteMultipartUpload.

[tatsuya6502]

Thank you! I'll give it a try.

[tatsuya6502]

My colleague tried the latest SDK on the master branch against the S3 API compatible storage and found that multipart upload works now. Thanks a lot for working on the fix!