Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade GuzzleHttp to 7.* #2515

Closed
2 tasks
utdrmac opened this issue Sep 5, 2022 · 9 comments
Closed
2 tasks

Upgrade GuzzleHttp to 7.* #2515

utdrmac opened this issue Sep 5, 2022 · 9 comments
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue

Comments

@utdrmac
Copy link

utdrmac commented Sep 5, 2022

Describe the feature

AWS PHP SDK uses GuzzleHttp 6.5.5 which is not compatible with PHP 8.
Reference: guzzle/guzzle#3071

Use Case

For PHP8 (which is current GA) support

Proposed Solution

Update composer to no longer allow < v7

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

3.235

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 8.1.8

@utdrmac utdrmac added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 5, 2022
@GrahamCampbell
Copy link
Contributor

I don't agree this is necessary. All that is necessary is just adjust the phar builds to drop PHP <7.2.5, or provide two phar builds, one with PHP 5.5.9 as the min version and 7.4.99 as the max version, and one with 7.2.5 as the max version. Guzzle 6 does not support PHP 8.

@utdrmac
Copy link
Author

utdrmac commented Sep 5, 2022

Well, whatever the method (I'm not familiar with the processes), it would be nice to get rid of all these float/int warnings every time we run the AWS API. And if a simple upgrade of an internal library is all that is needed, that's why I made this FR.

@SamRemis
Copy link
Member

I agree, we have been discussing dropping support for 7.1 and below, but unless we increase that to 7.2.5, then we will need to continue with two builds to provide backward compatibility. Since we just merged the PHP 8 PR today, we should definitely be taking steps towards this ASAP. I'll discuss with the team and get back to you

@yenfryherrerafeliz yenfryherrerafeliz removed the needs-triage This issue or PR still needs to be triaged. label Oct 3, 2022
@yenfryherrerafeliz yenfryherrerafeliz added p2 This is a standard priority issue m Effort estimation: medium and removed m Effort estimation: medium labels Nov 3, 2022
@utdrmac
Copy link
Author

utdrmac commented Dec 13, 2022

PHP 7.4 EOL'd Nov 3 022. 7.3 EOL Nov 2021. 8.2 is current GA and the AWS SDK spews all kinds of messages now, all related to Guzzle.

@crmpicco
Copy link

crmpicco commented Jun 1, 2023

Hi @SamRemis , are there any plans to support Guzzle 7.x?

@GrahamCampbell
Copy link
Contributor

This is already done, and can be closed.

@crmpicco
Copy link

crmpicco commented Jun 1, 2023

@GrahamCampbell Any idea why master comes with Guzzle 6.x?

@GrahamCampbell
Copy link
Contributor

It does not. You can run composer why guzzlehttp/guzzle to see what else is causing this.

@SamRemis SamRemis closed this as completed Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

5 participants