Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHVM compatibility update #899

Closed
elazar opened this issue Feb 1, 2016 · 4 comments
Closed

HHVM compatibility update #899

elazar opened this issue Feb 1, 2016 · 4 comments
Labels
documentation This is a problem with documentation. third-party This issue is related to third-party libraries or applications.

Comments

@elazar
Copy link

elazar commented Feb 1, 2016

From the FAQ:

The SDK does not currently run on HHVM, and won't be able to until the issue with the yield syntax in HHVM is resolved.

The last comment on that issue indicates that it was resolved in the HHVM 3.11 release for all cited use cases, which should include the AWS SDK as it was mentioned a few times. I'm not seeing any open HHVM issues directly related to support for the yield keyword, at least.

The current failure on the HHVM build of aws/aws-sdk-php doesn't appear to be related to the original issue with yield. It would be great if we could get an SDK version with full HHVM compatibility.

@jeskew
Copy link
Contributor

jeskew commented Feb 1, 2016

Unfortunately, Travis only tests against HHVM 3.6.6 at the moment. The latest failure of the current version of the SDK (V3) was caused by the yield syntax incompatibility. Based on what was mentioned in the HHVM issue, I expect v3 would work on HHVM 3.11, but I don't have a good way to automatically test all releases and pull requests until Travis upgrades their HHVM runtime.

The V2 failure linked to appears to be caused by an HHVM incompatibility in PHPUnit. I haven't investigated what's causing it, but it might also be fixed in 3.11.

@elazar
Copy link
Author

elazar commented Feb 2, 2016

@jeskew Don't know that this is an option you can consider, but it looks like it's possible to use HHVM 3.11 in a Trusty beta environment. See this issue for details.

@jeskew
Copy link
Contributor

jeskew commented Feb 2, 2016

I ran a test (#902) to see if the SDK was compatible with HHVM >=3.11. It appears that while the HHVM team fixed the syntax error that was thrown when yield was placed inside parentheses, yielding into generators still does not work the same in PHP and HHVM.

@jeskew
Copy link
Contributor

jeskew commented Feb 4, 2016

I opened a new issue on HHVM, as there is still an incompatibility with the way generators work between HHVM 3.11 and Zend PHP.

@jeskew jeskew closed this as completed in c97d732 Feb 8, 2016
@diehlaws diehlaws added third-party This issue is related to third-party libraries or applications. documentation This is a problem with documentation. and removed docs labels Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. third-party This issue is related to third-party libraries or applications.
Projects
None yet
Development

No branches or pull requests

3 participants