Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws::CloudSearchDomain::Client limits expression size #1181

Closed
joshuasiler opened this issue May 9, 2016 · 9 comments
Closed

Aws::CloudSearchDomain::Client limits expression size #1181

joshuasiler opened this issue May 9, 2016 · 9 comments
Labels
feature-request A feature should be added or improved.

Comments

@joshuasiler
Copy link

joshuasiler commented May 9, 2016

An undocumented limit of CloudSearch is that expression size (shown here http://docs.aws.amazon.com/cloudsearch/latest/developerguide/limits.html) is limited by half or more of the stated limit when using GET requests.

Gem should use POST by default, or at least have it as a configurable option. Any expression more than 4500 chars or so using this gem will fail with Aws::CloudSearchDomain::Errors::RequestEntityTooLarge, when the actual limit of the service is over 10K.

@trevorrowe trevorrowe added feature-request A feature should be added or improved. Version 2 labels May 16, 2016
@awood45
Copy link
Member

awood45 commented May 18, 2016

This is currently defined in the model itself, so default choices would come from that. It would be interesting to explore what it would take to allow configuration of HTTP verbs used by service calls.

@joshuasiler
Copy link
Author

joshuasiler commented May 18, 2016

Is it possible to change the default setting and just use POST across the board? A setting somewhere?

@awood45
Copy link
Member

awood45 commented Jun 3, 2016

Added to feature request backlog.

@awood45 awood45 closed this as completed Jun 3, 2016
@aladh
Copy link

aladh commented Sep 12, 2016

It looks like the java sdk implemented POST for CloudSearchDomain search requests. Would a similar implementation work for ruby? https://github.com/aws/aws-sdk-java/blob/fb1d42ee0e00dccf8a3290e04c367989ae5664fc/aws-java-sdk-cloudsearch/src/main/java/com/amazonaws/services/cloudsearchdomain/SwitchToPostHandler.java

@joshuasiler
Copy link
Author

Yes this is exactly what is needed.

@alexfarrill
Copy link

+1 for this feature

@cjyclaire
Copy link
Contributor

Soft ping, the feature PR has been merged, and will be tagged in today's release : )

@joshuasiler
Copy link
Author

Great to hear

@alexfarrill
Copy link

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

6 participants