Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waiters for ElasticBeanstalk #1259

Closed
caldwecr opened this issue Jul 29, 2016 · 6 comments
Closed

Add waiters for ElasticBeanstalk #1259

caldwecr opened this issue Jul 29, 2016 · 6 comments
Labels
feature-request A feature should be added or improved. service-api General API label for AWS Services.

Comments

@caldwecr
Copy link

When triggering operations that will run long (on the order of > 5 minutes and less than 24 hours) it would be useful to have predefined waiters available.

Presently I am looking for such support for update_environment operations.

@caldwecr caldwecr changed the title Add waiters for Elasticbeanstalk Add waiters for ElasticBeanstalk Jul 29, 2016
@awood45 awood45 added feature-request A feature should be added or improved. Version 2 labels Aug 2, 2016
@awood45
Copy link
Member

awood45 commented Aug 2, 2016

We're happy to take a PR for this, and will also consider as a feature request.

@awood45
Copy link
Member

awood45 commented Sep 9, 2016

Added to feature request backlog.

@awood45 awood45 closed this as completed Sep 9, 2016
@mullermp
Copy link
Contributor

Reopening - deprecating usage of Feature Requests backlog markdown file.

@mullermp mullermp reopened this Oct 21, 2019
@mullermp mullermp added waiter and removed v2 labels Oct 21, 2019
@mullermp
Copy link
Contributor

mullermp commented Jul 9, 2020

I'm sorry this feature request took too long. I reached out to the elastic beanstalk team but didn't really get traction, so I went and implemented these myself. I tested the correctness of them by creating, updating, and terminating an environment.

I'll push these changes upstream and they'll be deployed in their next release.

{
  "version": 2,
  "waiters": {
    "EnvironmentExists": {
      "delay": 5,
      "maxAttempts": 20,
      "operation": "DescribeEnvironments",
      "acceptors": [
        {
          "state": "success",
          "matcher": "pathAll",
          "argument": "Environments[].Status",
          "expected": "Ready"
        },
        {
          "state": "retry",
          "matcher": "pathAll",
          "argument": "Environments[].Status",
          "expected": "Launching"
        }
      ]
    },
    "EnvironmentUpdated": {
      "delay": 5,
      "maxAttempts": 20,
      "operation": "DescribeEnvironments",
      "acceptors": [
        {
          "state": "success",
          "matcher": "pathAll",
          "argument": "Environments[].Status",
          "expected": "Ready"
        },
        {
          "state": "retry",
          "matcher": "pathAll",
          "argument": "Environments[].Status",
          "expected": "Updating"
        }
      ]
    },
    "EnvironmentTerminated": {
      "delay": 5,
      "maxAttempts": 20,
      "operation": "DescribeEnvironments",
      "acceptors": [
        {
          "state": "success",
          "matcher": "pathAll",
          "argument": "Environments[].Status",
          "expected": "Terminated"
        },
        {
          "state": "retry",
          "matcher": "pathAll",
          "argument": "Environments[].Status",
          "expected": "Terminating"
        }
      ]
    }
  }
}

@mullermp
Copy link
Contributor

mullermp commented Jul 9, 2020

I've changed delay to 20 seconds because of how long it takes to create/delete environments in most cases.

@mullermp mullermp added service-api General API label for AWS Services. and removed waiter labels Jul 10, 2020
@mullermp
Copy link
Contributor

This is schedule for 7/17 (tomorrow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. service-api General API label for AWS Services.
Projects
None yet
Development

No branches or pull requests

3 participants