Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of service clients depends on latest version of core #1872

Closed
lwoggardner opened this issue Sep 6, 2018 · 16 comments
Closed

Comments

@lwoggardner
Copy link

Since todays release we started getting errors in our builds..

"error 06-Sep-2018 02:01:40 LoadError: cannot load such file -- aws-sdk-core/plugins/client_metrics_plugin.rb"

I'm not entirely sure why our Gemfile.lock was not being respected by bundle install but it was upgrading some of the clients, but not core.

build	06-Sep-2018 02:01:39	Using rake 12.3.1
build	06-Sep-2018 02:01:39	Using aws-sdk-core 3.19.0
build	06-Sep-2018 02:01:39	Using aws-sdk-autoscaling 1.5.0
build	06-Sep-2018 02:01:39	Using aws-sdk-cloudformation 1.4.0
build	06-Sep-2018 02:01:39	Using aws-sdk-cloudwatchlogs 1.6.0 (was 1.3.0)
build	06-Sep-2018 02:01:39	Using aws-sdk-dynamodb 1.12.0 (was 1.5.0)

Clearly dynamodb.1.12.0 depends now on core 3.26.0 so that it can require the above file.
However, the gemspec for dynamodb says - spec.add_dependency('aws-sdk-core', '~> 3')

Should it be more specific?

@BTheunissen
Copy link

I am having the same issue, I had to roll back to an older version of the gem 😞

@valscion
Copy link

valscion commented Sep 6, 2018

Yeah having the same issue as well. Can't upgrade to latest versions because of this.

@srchase srchase added the bug label Sep 6, 2018
@srchase
Copy link
Contributor

srchase commented Sep 6, 2018

@lwoggardner

Thanks for reporting this issue. We're looking at getting this resolved.

@awood45
Copy link
Member

awood45 commented Sep 6, 2018

I deeply apologize for the mistake here, I'm going to fix this first thing today. A workaround is to hard upgrade aws-sdk-core but yes, NEEDING to do that isn't correct. I clearly made a mistake when updating the gemspec generation code.

@awood45
Copy link
Member

awood45 commented Sep 6, 2018

I believe #1871 fixes this as planned, I need to look at the extent of this. Is dynamodb the only affected gem?

@awood45
Copy link
Member

awood45 commented Sep 6, 2018

Okay, this was an oversight on my part. Here are the affected gems:

  • aws-sdk-appstream
  • aws-sdk-dynamodb
  • aws-sdk-elasticloadbalancing
  • aws-sdk-rds
  • aws-sdk-s3

We'll have new versions of all service gems out today, but I had added plugins to core, yet my update to the gemspec generation logic was put into a separate commit. That was a mistake on my part.

@awood45 awood45 added the pending label Sep 6, 2018
@awood45
Copy link
Member

awood45 commented Sep 6, 2018

Here's a summary:

  • I'll post an update here when we push our next release, these gems will be usable with the latest updates after we get that out.
  • In the meantime, you can use the latest versions of the current gems by also upgrading aws-sdk-core to the latest version. That is essentially what this pull request will do.

@awood45
Copy link
Member

awood45 commented Sep 6, 2018

Update: The release for this is going through our release process now. Expect to be able to update in about 30 minutes from this post.

@awood45
Copy link
Member

awood45 commented Sep 6, 2018

This is fixed in the latest versions of each gem. Sorry about the churn here.

@awood45 awood45 closed this as completed Sep 6, 2018
@benjamin-cribb
Copy link

This, or something similar, also seems to be effecting aws-sdk-ssm

@awood45
Copy link
Member

awood45 commented Sep 10, 2018

What version of aws-sdk-ssm are you using? Are you seeing the same client error?

@benjamin-cribb
Copy link

1.24.0, yes, same client error. Rolling back to aws-sdk-ssm 1.22.0 fixed the problem

@awood45
Copy link
Member

awood45 commented Sep 10, 2018

What happens if you upgrade to 1.25.0? It does look like 1.24.0 may have been impacted by this issue.

@benjamin-cribb
Copy link

I had to update a bunch of other aws gems to use 1.25, but it also does work

@benjamin-cribb
Copy link

Try a later version of sns

@makeitgo
Copy link

makeitgo commented Feb 7, 2019

Thanks, I was able to update my bundle. I had to upgrade my s3 which updated my core .... bundle update aws-sdk-s3 We had another dependency that was locked to an earlier version. The error is now gone. Much happier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants