Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Add ability to specify AWS KMS master key for Upload function to AWS Lambda #56

Closed
Mutley5000 opened this issue Dec 15, 2016 · 3 comments
Assignees
Labels
feature-request New feature or enhancement. May require GitHub community feedback. lambda

Comments

@Mutley5000
Copy link

Mutley5000 commented Dec 15, 2016

I think it would be useful to add the ability to specify a AWS KMS master key for those that use server side encryption so that Lambda functions can be uploaded to S3 straight from the IDE using the Upload function to AWS Lambda option given by the AWS Lambda plugin.

@zhangzhx
Copy link
Contributor

Hi Mutley5000,

That's a very great callout. Thanks for the feedback, I will add this feature to our backlog and will let you know once this feature is released.

@zhangzhx zhangzhx self-assigned this Dec 15, 2016
@zhangzhx zhangzhx added the feature-request New feature or enhancement. May require GitHub community feedback. label Dec 15, 2016
@Mutley5000
Copy link
Author

Mutley5000 commented Dec 16, 2016

Hey zhangzhx,

No worries. Glad to help!

I was looking through the source code briefly and I believe it would need a change to com.amazonaws.eclipse.lambda.serverless.wizard.DeployServerlessProjectWizard.deployServerlessTemplate(). The upload @ line 140 could be modified to have an option to handle no KMS master key and one to handle with it. The option for handling with a key would need the extra parameter as listed here: http://docs.aws.amazon.com/AmazonS3/latest/dev/kms-using-sdks.html. I didn't have time to go through and find where the GUI changes need to be made to add the extra textbox and possibly checkbox (however you want to handle to selection of using a key or not).

@zhangzhx
Copy link
Contributor

This has been released in the latest version v201709262229.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback. lambda
Projects
None yet
Development

No branches or pull requests

2 participants