Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloudFormation JSON-files use light mode font colors in dark mode #329

Open
emahiq opened this issue Mar 23, 2023 · 1 comment
Open

CloudFormation JSON-files use light mode font colors in dark mode #329

emahiq opened this issue Mar 23, 2023 · 1 comment
Labels
bug We can reproduce the issue and confirmed it is a bug.

Comments

@emahiq
Copy link

emahiq commented Mar 23, 2023

Describe the bug
Syntax highlighting in CloudFormation JSON files uses light mode colors in dark mode

To Reproduce

  1. Create a new CloudFormation-file cfn.template.
  2. Open the file in Visual Studio with dark mode enabled
  3. Put valid CloudFormation JSON code in the file:
{
    "Resources": {
        "MyBucket": {
            "Type": "AWS::S3::Bucket",
            "Properties": {
                "BucketName": "my-bucket-name"
            }
        }
    }
}
  1. Notice how the font is using the colors for light mode, and not the dark mode colors as you would expect.

Expected behavior
Syntax should be displayed in dark mode colors

Screenshots
The above example in my editor
image

There are dark mode colors defined in the options (Tools -> Options -> Environment -> Fonts and colors) that aren't being used. Here you can see that the normal font color is used:
image

Computer

  • Windows Version: 10.0.19045 Build 19045
  • Visual Studio Version: Visual Studio Professional 2022 (17.5.3)
  • AWS Toolkit for Visual Studio Version: 1.39.0.0
@emahiq emahiq added the bug We can reproduce the issue and confirmed it is a bug. label Mar 23, 2023
@rbbarad
Copy link
Contributor

rbbarad commented Mar 28, 2023

Thank you for bringing this issue to our attention. I was able to reproduce the issue and we are investigating further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug We can reproduce the issue and confirmed it is a bug.
Projects
None yet
Development

No branches or pull requests

2 participants