Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with opentracing? #31

Open
zkanda opened this issue Dec 12, 2017 · 4 comments
Open

Integration with opentracing? #31

zkanda opened this issue Dec 12, 2017 · 4 comments

Comments

@zkanda
Copy link

zkanda commented Dec 12, 2017

Is there a plan to integrate it with some vendor neutral like opentracing?

@abhiksingh
Copy link

abhiksingh commented Dec 14, 2017

@zkanda could you please provide more information on what you're hoping to achieve with OpenTracing integration?

The reason I ask, is that today OpenTracing simply defines an instrumentation API and doesn't define a context (trace ID, parent ID, etc.) or backend data format. This implies that in theory the instrumentation library could be swapped between vendors and everything should still work as expected. However, in reality given the differences in the context and backend data formats between vendors this simply isn't possible unless you're open to swapping out the SDK's.

We would love to better understand your use case in order to provide or recommend a solution.

@nightlyone
Copy link

It might help adoption to at least support the Opentracing terminology (namely spans instead of segments) and keep the api compatible in terms of span generation and propagation. But this might need to be discussed at a cross language level at Amazon.

@yurishkuro
Copy link

unless you're open to swapping out the SDK's

swapping out the implementation of an interface (one line of code, from new X() to new Y()) is quite different from rewriting all your own (and your frameworks) code that uses that interface.

@abhiksingh
Copy link

abhiksingh commented Jul 27, 2018

@yurishkuro thank you for the feedback. We would love to see the OpenTracing community take a lead on this work as subject matter experts on the OpenTracing API. We would be happy to work with the community towards a solution similar to the exporter for X-Ray provided by OpenCensus

We continue to be very interested in the issue of standardized tracing data format and APIs as a topic and working with the community to evolve X-Ray over time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants