Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability in the library #599

Closed
rpodwika opened this issue Jun 23, 2023 · 6 comments
Closed

Vulnerability in the library #599

rpodwika opened this issue Jun 23, 2023 · 6 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@rpodwika
Copy link

https://www.mend.io/vulnerability-database/CVE-2022-25883

-> aws-xray-sdk-3.5.0.tgz (Root Library)

   -> aws-xray-sdk-core-3.5.0.tgz

     -> cls-hooked-4.2.2.tgz

       -> ❌ semver-5.7.1.tgz (Vulnerable Library)
      
      

@jhonnycordova
Copy link

Hello. Are you planning to fix this? Any workaround I can use in the meantime?. Thanks

@carolabadeer
Copy link
Contributor

carolabadeer commented Jun 29, 2023

Hi @rpodwika and @jhonnycordova, thanks for raising this issue

Do you mind clarifying where v5.7.1 is being brought in? I see semver v7.3.8 in the aws-xray-sdk-core package dependencies and semver v6.3.0 being pulled in from cls-hooked

PR #598 fixes the core package version, but the version being pulled in from cls-hooked is a transitive dependency

@kryten87
Copy link

kryten87 commented Jul 6, 2023

The cls-hooked package on the master branch does indeed have semver v6.3.0, but the v4.2.2 tag has semver v5.4.1. I'm not sure where 5.7.1 is coming from. In any event, the vulnerability described in the link above affects any version of semver prior to 7.5.2, so even installing from master will not resolve the problem.

The version from cls-hooked may be transitive, but it is enough to cause npm audit to complain.

@cortexcompiler
Copy link

cortexcompiler commented Jul 8, 2023

I am seeing this vulnerability flagged for any version of semver < 7.5.2:
https://security.snyk.io/vuln/SNYK-JS-SEMVER-3247795

The paths given where it is introduced through are:

aws-xray-sdk-core@3.5.0 > cls-hooked@4.2.2 > semver@5.7.1
aws-xray-sdk@3.5.0 > aws-xray-sdk-core@3.5.0 > cls-hooked@4.2.2 > semver@5.7.1

Note that this is flagged as a high severity vulnerability.

@carolabadeer
Copy link
Contributor

Hi all, thank you for your responses! We are actively working on a fix

@carolabadeer
Copy link
Contributor

carolabadeer commented Jul 19, 2023

Node SDK v3.5.1, which includes the fix for this security vulnerability, has been released
https://github.com/aws/aws-xray-sdk-node/releases/tag/aws-xray-sdk-node%403.5.1

@carolabadeer carolabadeer self-assigned this Oct 6, 2023
@carolabadeer carolabadeer added the dependencies Pull requests that update a dependency file label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

5 participants