Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.10 (removed asyncio loop keyword) #321

Closed
musicinmybrain opened this issue Dec 19, 2021 · 3 comments
Closed

Support Python 3.10 (removed asyncio loop keyword) #321

musicinmybrain opened this issue Dec 19, 2021 · 3 comments
Labels

Comments

@musicinmybrain
Copy link
Contributor

It would be nice to have official support for Python 3.10.

The main issue I see is that the loop parameter in the high-level asyncio APIs, deprecated since 3.8, is removed in 3.10. These are still used in quite a few places.

It’s not easy for me to run the full test suite, so it’s hard for me to know whether or not simply removing all such loop parameters without further changes to the code would fix Python 3.10 support without breaking anything on some older Python version that you still support.

@srprash
Copy link
Contributor

srprash commented Dec 20, 2021

Hi @musicinmybrain
Thanks for bringing this to our notice. I see that the potential impact of this API change could be in the async_context which uses asyncio.
We will have the change tested on our end soon to address the compatibility with Python 3.10.

@yan12125
Copy link
Contributor

I see that the potential impact of this API change could be in the async_context which uses asyncio.

Maybe an API change is not necessary. In async_context.py, loop is passed to asyncio.current_task(), which still accepts a loop argument as of Python 3.10.

@musicinmybrain
Copy link
Contributor Author

Python 3.10 and 3.11 seem to be properly supported as of 2.12.0, so I’m closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants