Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botocore is a dependency in setup.py but is not in requirements file #7

Closed
garnaat opened this issue Jun 27, 2016 · 2 comments
Closed

Comments

@garnaat
Copy link
Collaborator

garnaat commented Jun 27, 2016

No description provided.

@jamesls jamesls added bug and removed bug labels Jul 5, 2016
@jamesls
Copy link
Member

jamesls commented Jul 7, 2016

This is a little confusing so I've updated the contributing guide with more info.

The way I had envisioned this is that the setup.py is used for all dependencies needed to actually use chalice, so you'd either python setup.py install, pip install -e . or whatever you prefer. So if you just want to install chalice from source, or you want to install the latest yet to be released dev version this is all you'd need to do.

Then the various requirements files would be used for additional things.

So if you're interested in hacking on chalice, then requirements-dev.txt is all you need. If you just want to build docs (or say for readthedocs) you'd install requirements-docs.txt.

Does that seem reasonable?

@garnaat
Copy link
Collaborator Author

garnaat commented Jul 10, 2016

I think it's reasonable, especially if it's documented. It's just a bit different than I expected.

@jamesls jamesls closed this as completed Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants