Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EKS][request]: Add support for tagging ENIs provisioned for worker nodes #1496

Open
kishoreakshat opened this issue Sep 8, 2021 · 16 comments
Labels
EKS Managed Nodes EKS Managed Nodes EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue

Comments

@kishoreakshat
Copy link

Tell us about your request

We would like to have support for propagation of custom tags to ENIs being used by worker nodes.

Which service(s) is this request for?
EKS

Tell us about the problem you're trying to solve. What are you trying to do, and why is it hard?

Currently, if you add Resource Tags for Network Interfaces in a Launch Template and use this Launch Template to create/update a Managed Nodegroup, the new Launch Template created by created by EKS workflow does not copy these ENI resource tags and hence any custom tags are not propagated to the underlying ENIs.

Are you currently working around this issue?

There is no workaround currently. The only brute approach is to tag ENIs manually but that hardly helps in automating the process as nodes may get recycled and ENIs ay be detached and reattached.

We have already tried:

  1. aws autoscaling create-or-update-tags CLI command [1].

  2. using eksctl to apply tags

eksctl create nodegroup --managed --tags --cluster <cluster_name> --region <region_name>

but even with this, tags were not applied to ENIs.

[1] https://docs.aws.amazon.com/cli/latest/reference/autoscaling/create-or-update-tags.html

It would be great if this capability could be automated.

@nikitacr7
Copy link

+1. It'll be very good to have that enhancement

@julissamackey
Copy link

+1!

@toricls toricls added EKS Amazon Elastic Kubernetes Service EKS Managed Nodes EKS Managed Nodes Proposed Community submitted issue labels Sep 17, 2021
@toricls toricls changed the title Add support for tagging ENIs provisioned for worker nodes [EKS][request]: Add support for tagging ENIs provisioned for worker nodes Sep 17, 2021
@21sahilsethi
Copy link

+1

4 similar comments
@bubeamos
Copy link

+1

@markvankessel
Copy link

+1

@pranchals
Copy link

+1

@nls-gtomov
Copy link

+1

@gpaks
Copy link

gpaks commented Dec 13, 2023

+1 Does this issue still persists?

@hmontesdeoca
Copy link

hmontesdeoca commented Jan 10, 2024

+1 Please add this. I had a 1 to many relationship (Policy-> Role) with a multi-tenant set up and faced an issue for a week because the ENI tags were not being created.

@aarontavio
Copy link

+1

2 similar comments
@Kartoshnikov
Copy link

+1

@not-ajay
Copy link

not-ajay commented May 1, 2024

+1

@not-ajay
Copy link

not-ajay commented May 1, 2024

Need this for billing purposes, any update would be appreciated.

@dstockton
Copy link

+1

1 similar comment
@shencan
Copy link

shencan commented May 29, 2024

+1

@TedCat
Copy link

TedCat commented May 29, 2024

Public IP v4 addresses have become a paid service. Adding a tag to the ENI is a convenient way to distinguish the cost. Hope this feature can release asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EKS Managed Nodes EKS Managed Nodes EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests