Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EKS] [request]: Ability to change kube controller manager parameters such as '--terminated-pod-gc-threshold' #1544

Open
hshabbar opened this issue Oct 29, 2021 · 8 comments
Labels
EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue

Comments

@hshabbar
Copy link

hshabbar commented Oct 29, 2021

Community Note

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Tell us about your request
What do you want us to build?

Ability to set values for kube controller manager parameters such as --terminated-pod-gc-threshold

Which service(s) is this request for?
EKS

@hshabbar hshabbar added the Proposed Community submitted issue label Oct 29, 2021
@mikestef9 mikestef9 changed the title [service] [request]: Ability to change kube controller manager parameters such as '--terminated-pod-gc-threshold' [EKS] [request]: Ability to change kube controller manager parameters such as '--terminated-pod-gc-threshold' Nov 17, 2021
@mikestef9 mikestef9 added the EKS Amazon Elastic Kubernetes Service label Mar 10, 2022
@sidewinder12s
Copy link

@mikestef9 Is the value that EKS uses for this flag documented anywhere?

@dmegyesi
Copy link

@mikestef9 Is the value that EKS uses for this flag documented anywhere?

You can check it in Cloudwatch when you enable the control plane logging. In my EKS 1.21 cluster it's: --terminated-pod-gc-threshold="12500"

@sidewinder12s
Copy link

That's long ago deleted, though I'll take that as its set to the default.

@mtcode
Copy link

mtcode commented Nov 1, 2022

Another flag that should be configurable is --horizontal-pod-autoscaler-tolerance. The default value is 0.1, or 10%, but there are use cases to make the value smaller (more sensitive, more responsive) or larger.

@raravena80
Copy link

+1 we need this feature

@ozcb
Copy link

ozcb commented Nov 24, 2022

+1

@adamdougal
Copy link

Just to add to the list of parameters that we'd like configurable. --concurrent-horizontal-pod-autoscaler-syncs which is new in K8s 1.26.

@Aym3nTN
Copy link

Aym3nTN commented Jan 8, 2024

Is there like any reason to not allow overriding this --terminated-pod-gc-threshold default value? it's really a pain to have to clean up those terminated pods manually or having a cronjob to do it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EKS Amazon Elastic Kubernetes Service Proposed Community submitted issue
Projects
None yet
Development

No branches or pull requests

9 participants