Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate application name #6

Closed
efekarakus opened this issue Aug 21, 2019 · 3 comments
Closed

Validate application name #6

efekarakus opened this issue Aug 21, 2019 · 3 comments

Comments

@efekarakus
Copy link
Contributor

efekarakus commented Aug 21, 2019

Story

As a user that entered the app name to the ecs init prompt or flag,
I want the CLI to give me an error before it proceeds creating my resources,
So that I don't do additional wasted work before getting an error message.

Acceptance Criteria

  • Has to be less than 255 characters

This is because an app's name will be used as a tag value which has to be < 255 chars. Note: I'm not sure what this means for unicode characters we might want to test this out.

  • Must be alphanumeric (A-Za-z0-9)

We will use a combination of project name and application name to create the Logical ID of CFN resources. CFN has a restriction of alphanumeric ids.

  • Must be unique within the project.

Maybe we should hold onto the SDK validations until we have the project management steps done.

@efekarakus efekarakus created this issue from a note in Sprint 🏃‍♀️ (To do) Aug 21, 2019
@sonofachamp
Copy link
Contributor

Is checking for uniqueness within the project a local check of the Manifest file?

@kohidave
Copy link
Contributor

@sonofachamp - It depends on how our final project management approach, but I imagine we'll do a uniqueness check by querying SSM or a CP to see if the app already exists.

@sonofachamp
Copy link
Contributor

I've opened #19 to add some basic value validations and will open another issue to track the uniqueness within a project scope work.

@sonofachamp sonofachamp moved this from In progress to Reviewer approved in Sprint 🏃‍♀️ Aug 26, 2019
@sonofachamp sonofachamp moved this from Reviewer approved to Done in Sprint 🏃‍♀️ Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Sprint 🏃‍♀️
  
Pending release
Development

No branches or pull requests

3 participants