Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support addons with continuous delivery #650

Closed
efekarakus opened this issue Feb 11, 2020 · 0 comments · Fixed by #710
Closed

Support addons with continuous delivery #650

efekarakus opened this issue Feb 11, 2020 · 0 comments · Fixed by #710
Assignees
Labels
area/addon Issues about addons. type/enhancement Issues that are improvements for existing features.

Comments

@efekarakus
Copy link
Contributor

efekarakus commented Feb 11, 2020

Existing system

Here is our existing CodePipeline layout.
pipeline

Within the build stage of the pipeline, we run app package --output-dir infrastructure to generate the CloudFormation template from the manifest file and addons template (see #648)

Once the build stage completes, the infrastructure/ directory is added as an artifact to the PipelineBuiltArtifactBucket.

Required changes

  1. We need to set the appropriate value for AddonsTemplateURL in the Test stage so that the template url for the nested stack can be constructed in the application stack. We're proposing to leverage Fn::GetArtifactAtt with ParameterOverrides in each environment stage to retrieve the URL of the output artifact from the Build stage. So we would need to make the following change to pipeline_cfn.yml:
ParameterOverrides: |
  {
    "AddonsTemplateURL" : { "Fn::Join" : [ "/", [ "Fn::GetArtifactAtt" : ["BuildOutput", "URL"], "infrastructure", "{{$app}}.addons.stack.yml " ] ] }
  }
  1. However, we can't set the ParameterOverrides if the application does not have any addons!
    Therefore, we need to modify stack/pipeline.go to pass information to denote that a particular application is expected to have addons.

Parent story

#644

@efekarakus efekarakus added type/enhancement Issues that are improvements for existing features. area/addon Issues about addons. labels Feb 11, 2020
@efekarakus efekarakus added this to Backlog in Sprint 🏃‍♀️ via automation Feb 11, 2020
@iamhopaul123 iamhopaul123 self-assigned this Feb 29, 2020
@efekarakus efekarakus moved this from Backlog to In progress in Sprint 🏃‍♀️ Mar 3, 2020
@iamhopaul123 iamhopaul123 moved this from In progress to In review in Sprint 🏃‍♀️ Mar 5, 2020
Sprint 🏃‍♀️ automation moved this from In review to Pending release Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon Issues about addons. type/enhancement Issues that are improvements for existing features.
Projects
Sprint 🏃‍♀️
  
Pending release
Development

Successfully merging a pull request may close this issue.

2 participants