-
Notifications
You must be signed in to change notification settings - Fork 270
/
machinedeploymentupgrade_controller.go
298 lines (258 loc) Β· 11.6 KB
/
machinedeploymentupgrade_controller.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
/*
Copyright 2023.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package controllers
import (
"context"
"encoding/base64"
"encoding/json"
"fmt"
"time"
"github.com/go-logr/logr"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
kerrors "k8s.io/apimachinery/pkg/util/errors"
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
"sigs.k8s.io/cluster-api/util/patch"
ctrl "sigs.k8s.io/controller-runtime"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
anywherev1 "github.com/aws/eks-anywhere/pkg/api/v1alpha1"
"github.com/aws/eks-anywhere/pkg/constants"
)
const (
// mdUpgradeFinalizerName is the finalizer added to MachineDeploymentUpgrade objects to handle deletion.
mdUpgradeFinalizerName = "machinedeploymentupgrades.anywhere.eks.amazonaws.com/finalizer"
mdLabelIdentifier = "cluster.x-k8s.io/deployment-name"
)
// MachineDeploymentUpgradeReconciler reconciles a MachineDeploymentUpgrade object.
type MachineDeploymentUpgradeReconciler struct {
client client.Client
log logr.Logger
}
// NewMachineDeploymentUpgradeReconciler returns a new instance of MachineDeploymentUpgradeReconciler.
func NewMachineDeploymentUpgradeReconciler(client client.Client) *MachineDeploymentUpgradeReconciler {
return &MachineDeploymentUpgradeReconciler{
client: client,
log: ctrl.Log.WithName("MachineDeploymentUpgradeController"),
}
}
//+kubebuilder:rbac:groups=anywhere.eks.amazonaws.com,resources=machinedeploymentupgrades,verbs=get;list;watch;create;update;patch;delete
//+kubebuilder:rbac:groups=anywhere.eks.amazonaws.com,resources=machinedeploymentupgrades/status,verbs=get;update;patch
//+kubebuilder:rbac:groups=anywhere.eks.amazonaws.com,resources=machinedeploymentupgrades/finalizers,verbs=update
//+kubebuilder:rbac:groups=cluster.x-k8s.io,resources=machinesets,verbs=get;list;watch;update;patch
// Reconcile reconciles a MachineDeploymentUpgrade object.
// nolint:gocyclo
// TODO: Reduce high cyclomatic complexity: https://github.com/aws/eks-anywhere-internal/issues/2119
func (r *MachineDeploymentUpgradeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (result ctrl.Result, reterr error) {
log := r.log.WithValues("MachineDeploymentUpgrade", req.NamespacedName)
log.Info("Reconciling machine deployment upgrade object")
mdUpgrade := &anywherev1.MachineDeploymentUpgrade{}
if err := r.client.Get(ctx, req.NamespacedName, mdUpgrade); err != nil {
if apierrors.IsNotFound(err) {
return reconcile.Result{}, err
}
return ctrl.Result{}, err
}
mdUpgradePatchHelper, err := patch.NewHelper(mdUpgrade, r.client)
if err != nil {
return ctrl.Result{}, err
}
md := &clusterv1.MachineDeployment{}
if err := r.client.Get(ctx, types.NamespacedName{Name: mdUpgrade.Spec.MachineDeployment.Name, Namespace: mdUpgrade.Spec.MachineDeployment.Namespace}, md); err != nil {
return ctrl.Result{}, fmt.Errorf("getting MachineDeployment %s: %v", mdUpgrade.Spec.MachineDeployment.Name, err)
}
ms, err := r.getCurrentMachineSet(ctx, md)
if err != nil {
return ctrl.Result{}, err
}
defer func() {
err := r.updateStatus(ctx, log, mdUpgrade, ms)
if err != nil {
reterr = kerrors.NewAggregate([]error{reterr, err})
}
// Always attempt to patch the object and status after each reconciliation.
patchOpts := []patch.Option{}
// We want the observedGeneration to indicate, that the status shown is up-to-date given the desired spec of the same generation.
// However, if there is an error while updating the status, we may get a partial status update, In this case,
// a partially updated status is not considered up to date, so we should not update the observedGeneration
// Patch ObservedGeneration only if the reconciliation completed without error
if reterr == nil {
patchOpts = append(patchOpts, patch.WithStatusObservedGeneration{})
}
if err := patchMachineDeploymentUpgrade(ctx, mdUpgradePatchHelper, mdUpgrade, patchOpts...); err != nil {
reterr = kerrors.NewAggregate([]error{reterr, err})
}
// Only requeue if we are not already re-queueing and the Ready condition is false.
// We do this to be able to update the status continuously until it becomes ready,
// since there might be changes in state of the world that don't trigger reconciliation requests
if reterr == nil && !result.Requeue && result.RequeueAfter <= 0 && !mdUpgrade.Status.Ready {
result = ctrl.Result{RequeueAfter: 10 * time.Second}
}
}()
// Reconcile the MachineDeploymentUpgrade deletion if the DeletionTimestamp is set.
if !mdUpgrade.DeletionTimestamp.IsZero() {
return r.reconcileDelete(ctx, log, mdUpgrade)
}
// AddFinalizer is idempotent
controllerutil.AddFinalizer(mdUpgrade, mdUpgradeFinalizerName)
return r.reconcile(ctx, log, mdUpgrade)
}
// SetupWithManager sets up the controller with the Manager.
func (r *MachineDeploymentUpgradeReconciler) SetupWithManager(mgr ctrl.Manager) error {
return ctrl.NewControllerManagedBy(mgr).
For(&anywherev1.MachineDeploymentUpgrade{}).
Complete(r)
}
func (r *MachineDeploymentUpgradeReconciler) reconcile(ctx context.Context, log logr.Logger, mdUpgrade *anywherev1.MachineDeploymentUpgrade) (ctrl.Result, error) {
log.Info("Upgrading all worker nodes")
for _, machineRef := range mdUpgrade.Spec.MachinesRequireUpgrade {
nodeUpgrade, err := getNodeUpgrade(ctx, r.client, nodeUpgraderName(machineRef.Name))
if err != nil {
if apierrors.IsNotFound(err) {
nodeUpgrade = mdNodeUpgrader(machineRef, mdUpgrade.Spec.KubernetesVersion)
if err := r.client.Create(ctx, nodeUpgrade); err != nil {
return ctrl.Result{}, fmt.Errorf("failed to create node upgrader for machine %s: %v", machineRef.Name, err)
}
return ctrl.Result{}, nil
}
return ctrl.Result{}, fmt.Errorf("getting node upgrader for machine %s: %v", machineRef.Name, err)
}
if !nodeUpgrade.Status.Completed {
return ctrl.Result{}, nil
}
}
return ctrl.Result{}, nil
}
func (r *MachineDeploymentUpgradeReconciler) reconcileDelete(ctx context.Context, log logr.Logger, mdUpgrade *anywherev1.MachineDeploymentUpgrade) (ctrl.Result, error) {
log.Info("Reconcile MachineDeploymentUpgrade deletion")
for _, machineRef := range mdUpgrade.Spec.MachinesRequireUpgrade {
nodeUpgrade, err := getNodeUpgrade(ctx, r.client, nodeUpgraderName(machineRef.Name))
if err != nil {
if apierrors.IsNotFound(err) {
log.Info("Node Upgrader not found, skipping node upgrade deletion")
} else {
return ctrl.Result{}, fmt.Errorf("getting node upgrader for machine %s: %v", machineRef.Name, err)
}
} else {
log.Info("Deleting node upgrader", "Machine", machineRef.Name)
if err := r.client.Delete(ctx, nodeUpgrade); err != nil {
return ctrl.Result{}, fmt.Errorf("deleting node upgrader: %v", err)
}
}
}
// Remove the finalizer on MachineDeploymentUpgrade object
controllerutil.RemoveFinalizer(mdUpgrade, mdUpgradeFinalizerName)
return ctrl.Result{}, nil
}
func patchMachineDeploymentUpgrade(ctx context.Context, patchHelper *patch.Helper, mdUpgrade *anywherev1.MachineDeploymentUpgrade, patchOpts ...patch.Option) error {
// Always attempt to patch the object and status after each reconciliation.
return patchHelper.Patch(ctx, mdUpgrade, patchOpts...)
}
func (r *MachineDeploymentUpgradeReconciler) updateStatus(ctx context.Context, log logr.Logger, mdUpgrade *anywherev1.MachineDeploymentUpgrade, ms *clusterv1.MachineSet) error {
// When MachineDeploymentUpgrade is fully deleted, we do not need to update the status. Without this check
// the subsequent patch operations would fail if the status is updated after it is fully deleted.
if !mdUpgrade.DeletionTimestamp.IsZero() && len(mdUpgrade.GetFinalizers()) == 0 {
log.Info("MachineDeploymentUpgrade is deleted, skipping status update")
return nil
}
log.Info("Updating MachineDeploymentUpgrade status")
nodesUpgradeCompleted := 0
nodesUpgradeRequired := len(mdUpgrade.Spec.MachinesRequireUpgrade)
for _, machine := range mdUpgrade.Spec.MachinesRequireUpgrade {
nodeUpgrade, err := getNodeUpgrade(ctx, r.client, nodeUpgraderName(machine.Name))
if err != nil {
if apierrors.IsNotFound(err) {
continue
}
return fmt.Errorf("getting node upgrader for machine %s: %v", machine.Name, err)
}
if nodeUpgrade.Status.Completed {
nodesUpgradeCompleted++
nodesUpgradeRequired--
}
}
log.Info("Worker nodes ready", "upgraded", mdUpgrade.Status.Upgraded, "need-upgrade", mdUpgrade.Status.RequireUpgrade)
mdUpgrade.Status.Upgraded = int64(nodesUpgradeCompleted)
mdUpgrade.Status.RequireUpgrade = int64(nodesUpgradeRequired)
mdUpgrade.Status.Ready = nodesUpgradeRequired == 0
if mdUpgrade.Status.Ready {
machineSpecJSON, err := base64.StdEncoding.DecodeString(mdUpgrade.Spec.MachineSpecData)
if err != nil {
return fmt.Errorf("decoding value for %s with base64: %v", mdUpgrade.Spec.MachineSpecData, err)
}
machineSpec := clusterv1.MachineSpec{}
if err := json.Unmarshal(machineSpecJSON, &machineSpec); err != nil {
return fmt.Errorf("unmarshalling machineSpec: %v", err)
}
log.Info("Updating Spec in Machine Set", "machineset", ms.Name)
if err = r.updateMachineSet(ctx, ms, machineSpec); err != nil {
return err
}
}
return nil
}
func (r *MachineDeploymentUpgradeReconciler) getCurrentMachineSet(ctx context.Context, md *clusterv1.MachineDeployment) (*clusterv1.MachineSet, error) {
selector, err := metav1.LabelSelectorAsSelector(&metav1.LabelSelector{MatchLabels: map[string]string{mdLabelIdentifier: md.Name}})
if err != nil {
return nil, err
}
machineSetsList := &clusterv1.MachineSetList{}
if err := r.client.List(ctx, machineSetsList, &client.ListOptions{LabelSelector: selector}); err != nil {
return nil, fmt.Errorf("getting machine sets for %v: %v", md.Name, err)
}
revision, ok := md.Annotations[clusterv1.RevisionAnnotation]
if !ok {
return nil, fmt.Errorf("machineDeployment is missing %s annotation", clusterv1.RevisionAnnotation)
}
var currentMS *clusterv1.MachineSet
for _, ms := range machineSetsList.Items {
if ms.Annotations[clusterv1.RevisionAnnotation] == revision {
currentMS = &ms
break
}
}
if currentMS == nil {
return nil, fmt.Errorf("couldn't find machine set with revision version %s", revision)
}
return currentMS, nil
}
func (r *MachineDeploymentUpgradeReconciler) updateMachineSet(ctx context.Context, ms *clusterv1.MachineSet, spec clusterv1.MachineSpec) error {
patchHelper, err := patch.NewHelper(ms, r.client)
if err != nil {
return err
}
ms.Spec.Template.Spec = spec
if err := patchHelper.Patch(ctx, ms); err != nil {
return fmt.Errorf("updating spec for machineset %s: %v", ms.Name, err)
}
return nil
}
func mdNodeUpgrader(machineRef corev1.ObjectReference, kubernetesVersion string) *anywherev1.NodeUpgrade {
return &anywherev1.NodeUpgrade{
ObjectMeta: metav1.ObjectMeta{
Name: nodeUpgraderName(machineRef.Name),
Namespace: constants.EksaSystemNamespace,
},
Spec: anywherev1.NodeUpgradeSpec{
Machine: corev1.ObjectReference{
Kind: machineRef.Kind,
Namespace: constants.EksaSystemNamespace,
Name: machineRef.Name,
},
KubernetesVersion: kubernetesVersion,
},
}
}