Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency factory #310

Closed
Tracked by #93
g-gaston opened this issue Sep 27, 2021 · 0 comments · Fixed by #337
Closed
Tracked by #93

Dependency factory #310

g-gaston opened this issue Sep 27, 2021 · 0 comments · Fixed by #337

Comments

@g-gaston
Copy link
Member

g-gaston commented Sep 27, 2021

Right now the logic to construct all the different components/dependencies is duplicated on almost every command. This makes kind of cumbersome to add more dependencies to any entity.

Add a package/method/entity to consolidate this logic in one place, making easier to add more entities and/or change an existing entity dependencies.

Context for components upgrades: this will facilitate a lot to inject more executables as dependencies on each eks-a component’s owner: like kubectl or helm (eg. Cilium). This is necessary if we want each owner to be able to follow its own upgrade process and just expose a common interface

@g-gaston g-gaston added this to To do in Components upgrade via automation Sep 27, 2021
@g-gaston g-gaston added this to the next milestone Sep 27, 2021
@g-gaston g-gaston self-assigned this Sep 27, 2021
@g-gaston g-gaston moved this from To do to In progress in Components upgrade Sep 28, 2021
@g-gaston g-gaston moved this from In progress to Review in progress in Components upgrade Sep 28, 2021
@g-gaston g-gaston moved this from Review in progress to Reviewer approved in Components upgrade Sep 28, 2021
Components upgrade automation moved this from Reviewer approved to Done Sep 29, 2021
@jaxesn jaxesn removed this from the next milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants