-
Notifications
You must be signed in to change notification settings - Fork 17
/
periodic_healthcheck.go
252 lines (229 loc) · 9.54 KB
/
periodic_healthcheck.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
package controllers
import (
"context"
"fmt"
"strconv"
"sync"
"time"
etcdv1 "github.com/aws/etcdadm-controller/api/v1beta1"
"github.com/hashicorp/go-multierror"
"k8s.io/apimachinery/pkg/types"
"k8s.io/klog/v2"
clusterv1 "sigs.k8s.io/cluster-api/api/v1beta1"
"sigs.k8s.io/cluster-api/util"
"sigs.k8s.io/cluster-api/util/annotations"
"sigs.k8s.io/cluster-api/util/collections"
"sigs.k8s.io/cluster-api/util/conditions"
)
const (
maxUnhealthyCount = 5
)
type etcdHealthCheckConfig struct {
clusterToHttpClient sync.Map
}
type etcdadmClusterMemberHealthConfig struct {
unhealthyMembersFrequency map[string]int
unhealthyMembersToRemove map[string]*clusterv1.Machine
cluster *clusterv1.Cluster
endpoints string
ownedMachines collections.Machines
}
func (r *EtcdadmClusterReconciler) startHealthCheckLoop(ctx context.Context, done <-chan struct{}) {
r.Log.Info("Starting periodic healthcheck loop")
etcdadmClusterMapper := make(map[types.UID]etcdadmClusterMemberHealthConfig)
ticker := time.NewTicker(r.HealthCheckInterval)
defer ticker.Stop()
for {
select {
case <-done:
return
case <-ticker.C:
r.startHealthCheck(ctx, etcdadmClusterMapper)
}
}
}
func (r *EtcdadmClusterReconciler) startHealthCheck(ctx context.Context, etcdadmClusterMapper map[types.UID]etcdadmClusterMemberHealthConfig) {
etcdClusters := &etcdv1.EtcdadmClusterList{}
err := r.Client.List(ctx, etcdClusters)
if err != nil {
r.Log.Error(err, "Error listing etcdadm cluster objects")
return
}
for _, ec := range etcdClusters.Items {
log := r.Log.WithValues("EtcdadmCluster", klog.KObj(&ec))
if annotations.HasPaused(&ec) {
log.Info("EtcdadmCluster reconciliation is paused, skipping health checks")
continue
}
if val, set := ec.Annotations[etcdv1.HealthCheckRetriesAnnotation]; set {
if retries, err := strconv.Atoi(val); err != nil || retries < 0 {
log.Info(fmt.Sprintf("healthcheck-retries annotation configured with invalid value: %v", err))
} else if retries == 0 {
log.Info("healthcheck-retries annotation configured to 0, skipping health checks")
continue
}
}
if conditions.IsFalse(&ec, etcdv1.EtcdCertificatesAvailableCondition) {
log.Info("EtcdadmCluster certificates are not ready, skipping health checks")
continue
}
if !ec.Status.CreationComplete {
// etcdCluster not fully provisioned yet
log.Info("EtcdadmCluster is not ready, skipping health checks")
continue
}
if conditions.IsFalse(&ec, etcdv1.EtcdMachinesSpecUpToDateCondition) {
// etcdCluster is undergoing upgrade, some machines might not be ready yet, skip periodic healthcheck
log.Info("EtcdadmCluster machine specs are not up to date, skipping health checks")
continue
}
var cluster *clusterv1.Cluster
if clusterEntry, ok := etcdadmClusterMapper[ec.UID]; !ok {
cluster, err = util.GetOwnerCluster(ctx, r.Client, ec.ObjectMeta)
if err != nil {
log.Error(err, "Failed to retrieve owner Cluster from the API Server")
continue
}
if cluster == nil {
log.Info("Cluster Controller has not yet set OwnerRef on etcd cluster")
continue
}
ownedMachines := r.getOwnedMachines(ctx, cluster, ec)
etcdadmClusterMapper[ec.UID] = etcdadmClusterMemberHealthConfig{
unhealthyMembersFrequency: make(map[string]int),
unhealthyMembersToRemove: make(map[string]*clusterv1.Machine),
cluster: cluster,
ownedMachines: ownedMachines,
}
} else {
cluster = clusterEntry.cluster
if ec.Status.Endpoints != clusterEntry.endpoints {
clusterEntry.endpoints = ec.Status.Endpoints
ownedMachines := r.getOwnedMachines(ctx, cluster, ec)
clusterEntry.ownedMachines = ownedMachines
etcdadmClusterMapper[ec.UID] = clusterEntry
}
}
if err := r.periodicEtcdMembersHealthCheck(ctx, cluster, &ec, etcdadmClusterMapper); err != nil {
log.Error(err, "Error performing healthcheck")
continue
}
}
}
func (r *EtcdadmClusterReconciler) periodicEtcdMembersHealthCheck(ctx context.Context, cluster *clusterv1.Cluster, etcdCluster *etcdv1.EtcdadmCluster, etcdadmClusterMapper map[types.UID]etcdadmClusterMemberHealthConfig) error {
log := r.Log.WithValues("EtcdadmCluster", klog.KObj(etcdCluster))
if etcdCluster.Spec.Replicas == nil {
err := fmt.Errorf("Replicas is nil")
log.Error(err, "Error performing healthcheck")
return err
}
desiredReplicas := int(*etcdCluster.Spec.Replicas)
etcdMachines, err := collections.GetFilteredMachinesForCluster(ctx, r.uncachedClient, cluster, EtcdClusterMachines(cluster.Name, etcdCluster.Name))
if err != nil {
log.Error(err, "Error filtering machines for etcd cluster")
}
ownedMachines := etcdMachines.Filter(collections.OwnedMachines(etcdCluster))
currClusterHFConfig := etcdadmClusterMapper[etcdCluster.UID]
if len(etcdMachines) == 0 {
log.Info("Skipping healthcheck because there are no etcd machines")
return nil
}
// clean up old machines
for ip := range currClusterHFConfig.unhealthyMembersFrequency {
found := false
for _, machine := range etcdMachines {
if getMemberClientURL(getEtcdMachineAddress(machine)) == ip {
found = true
}
}
if !found {
log.Info("Removing member from unhealthyMembersFrequency, member does not exist", "member", ip)
delete(currClusterHFConfig.unhealthyMembersFrequency, ip)
}
}
log.Info("Performing healthchecks on the following etcd machines", "machines", klog.KObjSlice(etcdMachines.UnsortedList()))
for _, etcdMachine := range etcdMachines {
endpoint := getMachineEtcdEndpoint(etcdMachine)
if endpoint == "" {
log.Info("Member in bootstrap phase, ignoring")
continue
}
err := r.performEndpointHealthCheck(ctx, cluster, endpoint, false)
if err != nil {
currClusterHFConfig.unhealthyMembersFrequency[endpoint]++
// only check if machine should be removed if it is owned
if _, found := ownedMachines[etcdMachine.Name]; found {
// member failed healthcheck so add it to unhealthy map or update it's unhealthy count
log.Info("Member failed healthcheck, adding to unhealthy members list", "machine", etcdMachine, "IP", endpoint,
"unhealthy frequency", currClusterHFConfig.unhealthyMembersFrequency[endpoint])
unhealthyCount := maxUnhealthyCount
if val, set := etcdCluster.Annotations[etcdv1.HealthCheckRetriesAnnotation]; set {
retries, err := strconv.Atoi(val)
if err != nil || retries < 0 {
log.Info("healthcheck-retries annotation configured with invalid value, using default retries")
}
unhealthyCount = retries
}
if currClusterHFConfig.unhealthyMembersFrequency[endpoint] >= unhealthyCount {
log.Info("Adding to list of unhealthy members to remove", "member", endpoint)
// member has been unresponsive, add the machine to unhealthyMembersToRemove queue
currClusterHFConfig.unhealthyMembersToRemove[endpoint] = etcdMachine
}
}
} else {
_, markedUnhealthy := currClusterHFConfig.unhealthyMembersFrequency[endpoint]
if markedUnhealthy {
log.Info("Removing from total unhealthy members list", "member", endpoint)
delete(currClusterHFConfig.unhealthyMembersFrequency, endpoint)
}
// member passed healthcheck, so if it was previously added to unhealthy map, remove it since only consecutive failures should lead to member removal
_, markedToDelete := currClusterHFConfig.unhealthyMembersToRemove[endpoint]
if markedToDelete {
log.Info("Removing from list of unhealthy members to remove", "member", endpoint)
delete(currClusterHFConfig.unhealthyMembersToRemove, endpoint)
}
}
}
if len(currClusterHFConfig.unhealthyMembersToRemove) == 0 {
return nil
}
var retErr error
// check if quorum is perserved before deleting any machines
if len(etcdMachines)-len(currClusterHFConfig.unhealthyMembersFrequency) >= len(etcdMachines)/2+1 {
// only touch owned machines in health check alg
for machineEndpoint, machineToDelete := range currClusterHFConfig.unhealthyMembersToRemove {
// only remove one machine at a time
currentMachines := r.getOwnedMachines(ctx, cluster, *etcdCluster)
currentMachines = currentMachines.Filter(collections.Not(collections.HasDeletionTimestamp))
if len(currentMachines) < desiredReplicas {
log.Info("Waiting for new replica to be created before deleting additional replicas")
continue
}
if err := r.removeEtcdMachine(ctx, etcdCluster, cluster, machineToDelete, getEtcdMachineAddressFromClientURL(machineEndpoint)); err != nil {
// log and save error and continue deletion of other members, deletion of this member will be retried since it's still part of unhealthyMembersToRemove
if machineToDelete == nil {
log.Error(err, "error removing etcd member machine, machine not found", "endpoint", machineEndpoint)
} else {
log.Error(err, "error removing etcd member machine", "member", machineToDelete.Name, "endpoint", machineEndpoint)
}
retErr = multierror.Append(retErr, err)
continue
}
delete(currClusterHFConfig.unhealthyMembersToRemove, machineEndpoint)
}
if retErr != nil {
return retErr
}
} else {
log.Info("Not safe to remove etcd machines, quorum not preserved")
}
etcdCluster.Status.Ready = false
return r.Client.Status().Update(ctx, etcdCluster)
}
func (r *EtcdadmClusterReconciler) getOwnedMachines(ctx context.Context, cluster *clusterv1.Cluster, ec etcdv1.EtcdadmCluster) collections.Machines {
etcdMachines, err := collections.GetFilteredMachinesForCluster(ctx, r.uncachedClient, cluster, EtcdClusterMachines(cluster.Name, ec.Name))
if err != nil {
r.Log.Error(err, "Error filtering machines for etcd cluster")
}
return etcdMachines.Filter(collections.OwnedMachines(&ec))
}