-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing doc and tests for multi-key commands #1391
Add missing doc and tests for multi-key commands #1391
Conversation
* Add missing doc and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework docs and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Linter Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments.
java/client/src/main/java/glide/api/commands/GenericBaseCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
I wanted to emphasize |
…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Should be merged after #1390 |
java/client/src/main/java/glide/api/commands/HyperLogLogBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@shohamazon please, review and merge if it is OK for you. |
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
java/client/src/main/java/glide/api/commands/HyperLogLogBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/HyperLogLogBaseCommands.java
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
java/client/src/main/java/glide/api/commands/SortedSetBaseCommands.java
Outdated
Show resolved
Hide resolved
@@ -2171,6 +2171,8 @@ public T zinterstore( | |||
* To perform a <code>zinterstore</code> operation while specifying aggregation settings, use | |||
* {@link #zinterstore(String, KeysOrWeightedKeys, Aggregate)} | |||
* | |||
* @apiNote When in cluster mode, <code>destination</code> and all <code>keysOrWeightedKeys</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @apiNote When in cluster mode, <code>destination</code> and all <code>keysOrWeightedKeys</code> | |
* @apiNote When in cluster mode, <code>destination</code> and all keys <code>keysOrWeightedKeys</code> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this command the only one modified in this file? what about the other zinterstore and the rest of the commands?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that's a mistake - we don't add same-slot notice to transaction, because it is routed to a single node only.
We don't add that to docs in transaction on other clients too.
If you want me to add - please tell.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should, but whatever you think right
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
…d_crossslot Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Add missing doc and tests for multi-key commands (#226) * Add missing doc and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Rework docs and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Experiment Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Linter Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Address PR comments. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> * Update and fix doc and tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update node IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update tests. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Add version check. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Apply suggestions from code review Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com> * I HATE YOU SPOTLESS Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update python IT. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> --------- Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com> Co-authored-by: Shoham Elias <116083498+shohamazon@users.noreply.github.com>
. (valkey-io#1424) Hotfix for valkey-io#1391 - resolving conflict with valkey-io#1419. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Issue #, if available:
N/A
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.