Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Add EXPIRETIME and PEXPIRETIME commands. #1462

Merged
merged 7 commits into from
May 25, 2024

Conversation

Yury-Fridlyand
Copy link
Collaborator

Issue #, if available:
N/A

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Yury-Fridlyand and others added 2 commits May 24, 2024 12:50
* Add `EXPIRETIME` and `PEXPIRETIME` commands.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
…PIRETIME

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand Yury-Fridlyand added the java issues and fixes related to the java client label May 24, 2024
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner May 24, 2024 20:01
Copy link
Collaborator

@acarbonetto acarbonetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix Aaron's comments

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
@acarbonetto acarbonetto merged commit 3c04f3b into valkey-io:main May 25, 2024
46 checks passed
@acarbonetto acarbonetto deleted the java/integ_yuryf_EXPIRETIME branch May 25, 2024 00:21
cyip10 pushed a commit to Bit-Quill/valkey-glide that referenced this pull request Jun 24, 2024
* Java: Add `EXPIRETIME` and `PEXPIRETIME` commands. (#300)

* Add `EXPIRETIME` and `PEXPIRETIME` commands.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>

* Update expiretime docs

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Update docs for expiretime

Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>

* Apply suggestions from code review

---------

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Guian Gumpac <guian.gumpac@improving.com>
Co-authored-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Co-authored-by: Aaron <69273634+aaron-congo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java issues and fixes related to the java client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants