Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change object command names to follow camel-case #1559

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

aaron-congo
Copy link
Collaborator

Issue #, if available:
N/A

Description of changes:
Javascript follows camel-case for its variable naming convention. This PR updates the object command functions to follow camel-case.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aaron-congo aaron-congo requested a review from a team as a code owner June 12, 2024 23:31
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to update changelong?

@aaron-congo
Copy link
Collaborator Author

Do you need to update changelong?

I'm not sure... the command and the change to camel case will be released in the same version, so maybe not, but I'm not sure

@Yury-Fridlyand Yury-Fridlyand merged commit 832de8a into aws:main Jun 13, 2024
8 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the node/integ_acongo_object_camelcase branch June 13, 2024 19:12
cyip10 pushed a commit to Bit-Quill/glide-for-redis that referenced this pull request Jun 24, 2024
* Change object command names to follow camel-case

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants