Node: Allow chaining function calls on transaction. #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a builder-like pattern of calls, which is a bit more readable.
shachlanAmazon
requested review from
barshaul,
ikolomi,
shohamazon and
adanWattad
| @@ -77,21 +77,26 @@ import { redis_request } from "./ProtobufMessage"; | |||
| * await client.exec(transaction); | |||
| * [OK , "value"] | |||
| */ | |||
| export class BaseTransaction { | |||
| export class BaseTransaction<T extends BaseTransaction<T>> { | |||
There was a problem hiding this comment.
Please update example above
| @@ -866,6 +881,6 @@ export class Transaction extends BaseTransaction { | |||
| * Specific response types are documented alongside each method. | |||
| * | |||
| */ | |||
| export class ClusterTransaction extends BaseTransaction { | |||
| export class ClusterTransaction extends BaseTransaction<ClusterTransaction> { | |||
There was a problem hiding this comment.
Example here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a builder-like pattern of calls, which is a bit more readable.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.