Build .NET sources by default when running jsii-pacmak.
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stops outputting the .tgz for 'npm pack' in the package directory, instead put it in a specially created temporary directory. This avoids concurrent executions depending on the same path & deleting each other's files.
RomainMuller
force-pushed
the
pirocchi/build
branch
from
b0d7e22
to
81fc65a
Compare
eladb
suggested changes
Aug 8, 2018
|
|
||
| # Run integration tests | ||
| echo "Running integration tests" | ||
| #dotnet build -c Release ./test/Amazon.JSII.Runtime.IntegrationTests |
| @@ -7,7 +7,8 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\Amazon.JSII.Tests.Calculator\Amazon.JSII.Tests.Calculator.csproj" /> | |||
| <PackageReference Include="Amazon.JSII.Tests.Calculator" Version="0.6.2" /> | |||
| <!--<ProjectReference Include="..\Amazon.JSII.Tests.Calculator\Amazon.JSII.Tests.Calculator.csproj" />--> | |||
| @@ -2,8 +2,9 @@ | |||
| <configuration> | |||
| <packageSources> | |||
| <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" /> | |||
| <add key="jsii-dotnet-jsonmodel" value="../node_modules/jsii-dotnet-jsonmodel/bin/Release/NuGet" /> | |||
| <add key="jsii-dotnet-runtime" value="../bin/Release/NuGet" /> | |||
| <add key="jsii-dotnet-runtime" value="../node_modules/jsii-dotnet-runtime/bin/Release/NuGet" /> | |||
There was a problem hiding this comment.
looks like it's trying to depend on itself
There was a problem hiding this comment.
No - it's the jsii-dotnet-runtime-test depending on jsii-dotnet-runtime.
| @@ -4,5 +4,4 @@ | |||
| # bundle only... | |||
There was a problem hiding this comment.
not needed (we don't "npm pack" this)
| @@ -20,7 +20,7 @@ process.stdout.write(`<?xml version="1.0" encoding="UTF-8"?> | |||
| <dependency> | |||
| <groupId>software.amazon.jsii.tests</groupId> | |||
| <artifactId>calculator</artifactId> | |||
| <version>[0.5.0-beta,)</version> | |||
| <version>[0.6.2,)</version> | |||
There was a problem hiding this comment.
This should come from package.json
| @@ -1,8 +1,14 @@ | |||
| import childProcess = require('child_process'); | |||
| import fs = require('fs-extra'); | |||
| import jsiiDotNetJsonModel = require('jsii-dotnet-jsonmodel'); | |||
There was a problem hiding this comment.
This must be within try-catch because it's a devDependency
eladb
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jsii-dotnet-runtime's integration tests into a separate package, which breaks a dependency loop withjsii-pacmak.PackageReferences for assemblies, rather thanProjectReferences.Target.buildfor .NET.