Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsii: Add "install" integration tests #314

Closed
eladb opened this issue Nov 12, 2018 · 2 comments
Closed

jsii: Add "install" integration tests #314

eladb opened this issue Nov 12, 2018 · 2 comments
Assignees
Labels
effort/small Small work item – less than a day of effort ops-excellence Operational Excellence

Comments

@eladb
Copy link
Contributor

eladb commented Nov 12, 2018

To avoid issues like #313, we should include some integration tests in our pipeline that "npm installs" jsii from tarballs. This can be achieved either by "npm install js/*.tgz" or by using verdaccio.

@eladb eladb added the ops-excellence Operational Excellence label Nov 12, 2018
@fulghum fulghum added the effort/medium Medium work item – a couple days of effort label Dec 12, 2018
@eladb eladb changed the title Add "install" integration tests jsii: Add "install" integration tests Jan 8, 2019
@sam-goodwin
Copy link

I think we can re-use a bunch of the existing tests - add a JSII 'target' (or something) environment variable to switch between behavior. Saves re-doing veradccio and less boilerplate such as installing, checking canary mode, etc.

@eladb
Copy link
Contributor Author

eladb commented Jan 10, 2019

Can we extract the verdaccio stuff to a scripts that’s reusable between Jsii and cdk tests?

@fulghum fulghum removed the effort/medium Medium work item – a couple days of effort label Feb 18, 2019
@fulghum fulghum assigned rix0rrr and unassigned sam-goodwin Feb 18, 2019
@rix0rrr rix0rrr closed this as completed Feb 21, 2019
@fulghum fulghum added the effort/small Small work item – less than a day of effort label Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small Small work item – less than a day of effort ops-excellence Operational Excellence
Projects
None yet
Development

No branches or pull requests

4 participants