fix(rosetta): incorrect transliteration for selective imports #3508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go does nto support "selective" imports, and has limited symbol aliasing
support. Instead of attempting to transliterate selective imports with
a one-to-one semantic mapping, resolve the imported symbols and emit the
correct qualified original name instead.
This results in more idiomatic (and likely more correct) go code.
For example:
```ts
import { Foo as RenamedFoo, Bar } from 'baz';
const foo = new RenamedFoo();
Bar.baz(foo);
```
Should transliterate to something looking like:
```go
import "github.com/aws-samples/dummy/baz"
foo := baz.NewFoo()
Bar_baz(foo)
```
MrArnoldPalmer
approved these changes
May 2, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go does nto support "selective" imports, and has limited symbol aliasing
support. Instead of attempting to transliterate selective imports with
a one-to-one semantic mapping, resolve the imported symbols and emit the
correct qualified original name instead.
This results in more idiomatic (and likely more correct) go code.
For example:
Should transliterate to something looking like:
Bonus content:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.